You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Vinay Varma <vi...@citrix.com> on 2014/11/03 07:19:37 UTC
Re: Review Request 27017: CLOUDSTACK-6282: Added newly automated
tests and also modified some existing tests to remove dependency
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27017/
-----------------------------------------------------------
(Updated Nov. 3, 2014, 6:19 a.m.)
Review request for cloudstack, Alex Brett and Santhosh Edukulla.
Changes
-------
New diff file has been uploaded after make changes as per the review comments. Please review the same and do the needful
Bugs: CLOUDSTACK-6282
https://issues.apache.org/jira/browse/CLOUDSTACK-6282
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6282: Added newly automated tests and also modified some existing tests to remove dependency
Diffs (updated)
-----
test/integration/component/test_escalations_instances.py 1aaa688
test/integration/component/test_escalations_snapshots.py 4b6b7f5
test/integration/component/test_escalations_templates.py 78028bc
test/integration/component/test_escalations_volumes.py 7290325
test/integration/component/test_escalations_vpncustomergateways.py b09930a
tools/marvin/marvin/cloudstackTestClient.py ce7ffc9
tools/marvin/marvin/lib/base.py 77faeeb
tools/marvin/marvin/lib/utils.py b58b59d
Diff: https://reviews.apache.org/r/27017/diff/
Testing
-------
Attached are the results files for each of the file modified and the results shows everything is fine
File Attachments
----------------
Instancesresults.txt
https://reviews.apache.org/media/uploaded/files/2014/10/22/6ea95260-f31e-4fdd-a9f3-f30bac872df5__Instancesresults.txt
Snapshotsresults.txt
https://reviews.apache.org/media/uploaded/files/2014/10/22/a91e862c-dc2e-403e-85e4-6479eefcd9d1__Snapshotsresults.txt
Templatesresults.txt
https://reviews.apache.org/media/uploaded/files/2014/10/22/545fd06e-4975-4330-8390-3723d944ec2b__Templatesresults.txt
Voumesresults.txt
https://reviews.apache.org/media/uploaded/files/2014/10/22/9932b16c-684f-41ce-b6f9-192fe887c2b8__Voumesresults.txt
VPNCustomerGatewaysresults.txt
https://reviews.apache.org/media/uploaded/files/2014/10/22/58c5f08e-cac7-4873-a922-8c874a9a8e3a__VPNCustomerGatewaysresults.txt
Thanks,
Vinay Varma
Re: Review Request 27017: CLOUDSTACK-6282: Added newly automated
tests and also modified some existing tests to remove dependency
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27017/#review79014
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On Nov. 3, 2014, 6:19 a.m., Vinay Varma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27017/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 6:19 a.m.)
>
>
> Review request for cloudstack, Alex Brett and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6282: Added newly automated tests and also modified some existing tests to remove dependency
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_instances.py 1aaa688
> test/integration/component/test_escalations_snapshots.py 4b6b7f5
> test/integration/component/test_escalations_templates.py 78028bc
> test/integration/component/test_escalations_volumes.py 7290325
> test/integration/component/test_escalations_vpncustomergateways.py b09930a
> tools/marvin/marvin/cloudstackTestClient.py ce7ffc9
> tools/marvin/marvin/lib/base.py 77faeeb
> tools/marvin/marvin/lib/utils.py b58b59d
>
> Diff: https://reviews.apache.org/r/27017/diff/
>
>
> Testing
> -------
>
> Attached are the results files for each of the file modified and the results shows everything is fine
>
>
> File Attachments
> ----------------
>
> Instancesresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/10/22/6ea95260-f31e-4fdd-a9f3-f30bac872df5__Instancesresults.txt
> Snapshotsresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/10/22/a91e862c-dc2e-403e-85e4-6479eefcd9d1__Snapshotsresults.txt
> Templatesresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/10/22/545fd06e-4975-4330-8390-3723d944ec2b__Templatesresults.txt
> Voumesresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/10/22/9932b16c-684f-41ce-b6f9-192fe887c2b8__Voumesresults.txt
> VPNCustomerGatewaysresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/10/22/58c5f08e-cac7-4873-a922-8c874a9a8e3a__VPNCustomerGatewaysresults.txt
>
>
> Thanks,
>
> Vinay Varma
>
>
RE: Review Request 27017: CLOUDSTACK-6282: Added newly automated
tests and also modified some existing tests to remove dependency
Posted by Vinay Vegesna <vi...@citrix.com>.
Hi Santhosh,
Alex has reviewed below review request and marked it as “Ship it”, so can you please assign it to appropriate person to get it committed.
Thanks,
Vinay
From: Alex Brett [mailto:noreply@reviews.apache.org] On Behalf Of Alex Brett
Sent: Monday, November 24, 2014 9:45 PM
To: Alex Brett; Santhosh Edukulla
Cc: Vinay Vegesna; cloudstack
Subject: Re: Review Request 27017: CLOUDSTACK-6282: Added newly automated tests and also modified some existing tests to remove dependency
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27017/
Ship it!
Ship It!
- Alex Brett
On November 3rd, 2014, 6:19 a.m. UTC, Vinay Varma wrote:
Review request for cloudstack, Alex Brett and Santhosh Edukulla.
By Vinay Varma.
Updated Nov. 3, 2014, 6:19 a.m.
Bugs: CLOUDSTACK-6282<https://issues.apache.org/jira/browse/CLOUDSTACK-6282>
Repository: cloudstack-git
Description
CLOUDSTACK-6282: Added newly automated tests and also modified some existing tests to remove dependency
Testing
Attached are the results files for each of the file modified and the results shows everything is fine
Diffs
* test/integration/component/test_escalations_instances.py (1aaa688)
* test/integration/component/test_escalations_snapshots.py (4b6b7f5)
* test/integration/component/test_escalations_templates.py (78028bc)
* test/integration/component/test_escalations_volumes.py (7290325)
* test/integration/component/test_escalations_vpncustomergateways.py (b09930a)
* tools/marvin/marvin/cloudstackTestClient.py (ce7ffc9)
* tools/marvin/marvin/lib/base.py (77faeeb)
* tools/marvin/marvin/lib/utils.py (b58b59d)
View Diff<https://reviews.apache.org/r/27017/diff/>
File Attachments
• Instancesresults.txt<https://reviews.apache.org/media/uploaded/files/2014/10/22/6ea95260-f31e-4fdd-a9f3-f30bac872df5__Instancesresults.txt>
• Snapshotsresults.txt<https://reviews.apache.org/media/uploaded/files/2014/10/22/a91e862c-dc2e-403e-85e4-6479eefcd9d1__Snapshotsresults.txt>
• Templatesresults.txt<https://reviews.apache.org/media/uploaded/files/2014/10/22/545fd06e-4975-4330-8390-3723d944ec2b__Templatesresults.txt>
• Voumesresults.txt<https://reviews.apache.org/media/uploaded/files/2014/10/22/9932b16c-684f-41ce-b6f9-192fe887c2b8__Voumesresults.txt>
• VPNCustomerGatewaysresults.txt<https://reviews.apache.org/media/uploaded/files/2014/10/22/58c5f08e-cac7-4873-a922-8c874a9a8e3a__VPNCustomerGatewaysresults.txt>
Re: Review Request 27017: CLOUDSTACK-6282: Added newly automated
tests and also modified some existing tests to remove dependency
Posted by Alex Brett <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27017/#review62786
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Brett
On Nov. 3, 2014, 6:19 a.m., Vinay Varma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27017/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 6:19 a.m.)
>
>
> Review request for cloudstack, Alex Brett and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6282: Added newly automated tests and also modified some existing tests to remove dependency
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_instances.py 1aaa688
> test/integration/component/test_escalations_snapshots.py 4b6b7f5
> test/integration/component/test_escalations_templates.py 78028bc
> test/integration/component/test_escalations_volumes.py 7290325
> test/integration/component/test_escalations_vpncustomergateways.py b09930a
> tools/marvin/marvin/cloudstackTestClient.py ce7ffc9
> tools/marvin/marvin/lib/base.py 77faeeb
> tools/marvin/marvin/lib/utils.py b58b59d
>
> Diff: https://reviews.apache.org/r/27017/diff/
>
>
> Testing
> -------
>
> Attached are the results files for each of the file modified and the results shows everything is fine
>
>
> File Attachments
> ----------------
>
> Instancesresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/10/22/6ea95260-f31e-4fdd-a9f3-f30bac872df5__Instancesresults.txt
> Snapshotsresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/10/22/a91e862c-dc2e-403e-85e4-6479eefcd9d1__Snapshotsresults.txt
> Templatesresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/10/22/545fd06e-4975-4330-8390-3723d944ec2b__Templatesresults.txt
> Voumesresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/10/22/9932b16c-684f-41ce-b6f9-192fe887c2b8__Voumesresults.txt
> VPNCustomerGatewaysresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/10/22/58c5f08e-cac7-4873-a922-8c874a9a8e3a__VPNCustomerGatewaysresults.txt
>
>
> Thanks,
>
> Vinay Varma
>
>