You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/03/19 00:19:23 UTC
Review Request: Fixed slave to properly schedule all old directories for
garbage collection.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9997/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/slave/slave.hpp dadd06850565d07b46cea2f581661fb57a121118
src/slave/slave.cpp 912499e4cb34afa9bcc1556fd9536581001933ca
src/tests/gc_tests.cpp a9a7a439702ab87d5384c2d1b8afc0b17dab4e62
src/tests/utils.hpp 50203579f1ea14ee751c12a373047e9295e4ebb3
Diff: https://reviews.apache.org/r/9997/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to properly schedule work and meta
directories for garbage collection.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9997/#review18778
-----------------------------------------------------------
Will you be updating this to use the new testing abstractions?
- Ben Mahler
On April 8, 2013, 4:09 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9997/
> -----------------------------------------------------------
>
> (Updated April 8, 2013, 4:09 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
> src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa
> src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d
> src/slave/status_update_manager.hpp e6ca40c5c05c0952cf76fb1db7eff2e4270c0d24
> src/slave/status_update_manager.cpp 044d245f370ef23ddc67fadbf7f8fe9d75dd662a
> src/tests/gc_tests.cpp 037fe096179596a6bb9359b4258c2afafee300f9
> src/tests/slave_recovery_tests.cpp b4276edd09282640fa167cc70d1ab2b1deab3225
> src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252
>
> Diff: https://reviews.apache.org/r/9997/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed slave to properly schedule work and meta
directories for garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9997/#review19035
-----------------------------------------------------------
Ship it!
src/slave/slave.hpp
<https://reviews.apache.org/r/9997/#comment39557>
Put a comment about internal class.
src/slave/slave.hpp
<https://reviews.apache.org/r/9997/#comment39558>
ditto
src/slave/slave.cpp
<https://reviews.apache.org/r/9997/#comment39559>
s/file/entry
src/slave/slave.cpp
<https://reviews.apache.org/r/9997/#comment39560>
skip files. and move path down.
src/tests/gc_tests.cpp
<https://reviews.apache.org/r/9997/#comment39562>
latest abstractions
- Vinod Kone
On April 9, 2013, 8:59 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9997/
> -----------------------------------------------------------
>
> (Updated April 9, 2013, 8:59 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
> src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa
> src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d
> src/slave/status_update_manager.hpp e6ca40c5c05c0952cf76fb1db7eff2e4270c0d24
> src/slave/status_update_manager.cpp 044d245f370ef23ddc67fadbf7f8fe9d75dd662a
> src/tests/gc_tests.cpp 8c2e6e137748b9c8fa3db826752bed6a03c6c92f
> src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e
>
> Diff: https://reviews.apache.org/r/9997/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed slave to properly schedule work and meta
directories for garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9997/
-----------------------------------------------------------
(Updated April 17, 2013, 6:39 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
comments and rebase. no need for review.
Description
-------
See summary.
Diffs (updated)
-----
src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa
src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d
src/slave/status_update_manager.hpp e6ca40c5c05c0952cf76fb1db7eff2e4270c0d24
src/slave/status_update_manager.cpp 044d245f370ef23ddc67fadbf7f8fe9d75dd662a
src/tests/gc_tests.cpp 872faa74d7a4b71ea4e89d73f450b24c5031e876
src/tests/slave_recovery_tests.cpp 7be332b74367869e2b4c847fea348535cc526a23
Diff: https://reviews.apache.org/r/9997/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to properly schedule work and meta
directories for garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9997/
-----------------------------------------------------------
(Updated April 12, 2013, 11:19 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
Addressed comments. No Need For Review (NNFR).
Description
-------
See summary.
Diffs (updated)
-----
src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa
src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d
src/slave/status_update_manager.hpp e6ca40c5c05c0952cf76fb1db7eff2e4270c0d24
src/slave/status_update_manager.cpp 044d245f370ef23ddc67fadbf7f8fe9d75dd662a
src/tests/gc_tests.cpp 1330a72534b2175e049aaa092af99a6e1160157d
src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e
Diff: https://reviews.apache.org/r/9997/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to properly schedule work and meta
directories for garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9997/
-----------------------------------------------------------
(Updated April 9, 2013, 8:59 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased off trunk and fixed test to use latest abstractions.
Description
-------
See summary.
Diffs (updated)
-----
src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa
src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d
src/slave/status_update_manager.hpp e6ca40c5c05c0952cf76fb1db7eff2e4270c0d24
src/slave/status_update_manager.cpp 044d245f370ef23ddc67fadbf7f8fe9d75dd662a
src/tests/gc_tests.cpp 8c2e6e137748b9c8fa3db826752bed6a03c6c92f
src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e
Diff: https://reviews.apache.org/r/9997/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to properly schedule work and meta
directories for garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9997/
-----------------------------------------------------------
(Updated April 8, 2013, 4:09 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
...
Description
-------
See summary.
Diffs (updated)
-----
src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa
src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d
src/slave/status_update_manager.hpp e6ca40c5c05c0952cf76fb1db7eff2e4270c0d24
src/slave/status_update_manager.cpp 044d245f370ef23ddc67fadbf7f8fe9d75dd662a
src/tests/gc_tests.cpp 037fe096179596a6bb9359b4258c2afafee300f9
src/tests/slave_recovery_tests.cpp b4276edd09282640fa167cc70d1ab2b1deab3225
src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252
Diff: https://reviews.apache.org/r/9997/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to properly schedule work and meta
directories for garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9997/
-----------------------------------------------------------
(Updated April 2, 2013, 1:59 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu.
Changes
-------
status update manager no longer deletes task meta directory.
Description
-------
See summary.
Diffs (updated)
-----
src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa
src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d
src/slave/status_update_manager.hpp e6ca40c5c05c0952cf76fb1db7eff2e4270c0d24
src/slave/status_update_manager.cpp 044d245f370ef23ddc67fadbf7f8fe9d75dd662a
src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab
src/tests/slave_recovery_tests.cpp 47f9b0f215af2fb9bc300e0c92535b6f91afa5cd
src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252
Diff: https://reviews.apache.org/r/9997/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to properly schedule work and meta
directories for garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9997/
-----------------------------------------------------------
(Updated March 29, 2013, 9:47 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased off trunk.
Description
-------
See summary.
Diffs (updated)
-----
src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa
src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d
src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab
src/tests/slave_recovery_tests.cpp 47f9b0f215af2fb9bc300e0c92535b6f91afa5cd
src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252
Diff: https://reviews.apache.org/r/9997/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to properly schedule work and meta
directories for garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9997/
-----------------------------------------------------------
(Updated March 28, 2013, 11:26 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased off https://reviews.apache.org/r/10142/
Description
-------
See summary.
Diffs (updated)
-----
src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
src/slave/slave.cpp 091ec5ed19924aef31b761e68b70b8d042f9a9b7
src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d
src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab
src/tests/slave_recovery_tests.cpp 47f9b0f215af2fb9bc300e0c92535b6f91afa5cd
src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252
Diff: https://reviews.apache.org/r/9997/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to properly schedule work and meta
directories for garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
> On March 26, 2013, 5:50 p.m., Benjamin Hindman wrote:
> > I'll assume this will be rebased on the refactor?
you assume correctly.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9997/#review18400
-----------------------------------------------------------
On March 22, 2013, 9:39 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9997/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 9:39 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
> src/slave/slave.cpp 091ec5ed19924aef31b761e68b70b8d042f9a9b7
> src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d
> src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab
> src/tests/slave_recovery_tests.cpp 47f9b0f215af2fb9bc300e0c92535b6f91afa5cd
> src/tests/utils.hpp 50203579f1ea14ee751c12a373047e9295e4ebb3
>
> Diff: https://reviews.apache.org/r/9997/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed slave to properly schedule work and meta
directories for garbage collection.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9997/#review18400
-----------------------------------------------------------
I'll assume this will be rebased on the refactor?
- Benjamin Hindman
On March 22, 2013, 9:39 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9997/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 9:39 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
> src/slave/slave.cpp 091ec5ed19924aef31b761e68b70b8d042f9a9b7
> src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d
> src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab
> src/tests/slave_recovery_tests.cpp 47f9b0f215af2fb9bc300e0c92535b6f91afa5cd
> src/tests/utils.hpp 50203579f1ea14ee751c12a373047e9295e4ebb3
>
> Diff: https://reviews.apache.org/r/9997/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed slave to properly schedule work and meta
directories for garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9997/
-----------------------------------------------------------
(Updated March 22, 2013, 9:39 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
refactored gc to happen with recovery.
Summary (updated)
-----------------
Fixed slave to properly schedule work and meta directories for garbage collection.
Description
-------
See summary.
Diffs (updated)
-----
src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
src/slave/slave.cpp 091ec5ed19924aef31b761e68b70b8d042f9a9b7
src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d
src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab
src/tests/slave_recovery_tests.cpp 47f9b0f215af2fb9bc300e0c92535b6f91afa5cd
src/tests/utils.hpp 50203579f1ea14ee751c12a373047e9295e4ebb3
Diff: https://reviews.apache.org/r/9997/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to properly schedule all old directories for
garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9997/#review18111
-----------------------------------------------------------
src/slave/slave.cpp
<https://reviews.apache.org/r/9997/#comment38232>
Do this inline with recovery, when checkpointing is default.
src/tests/gc_tests.cpp
<https://reviews.apache.org/r/9997/#comment38234>
split
src/tests/gc_tests.cpp
<https://reviews.apache.org/r/9997/#comment38233>
split doall
- Vinod Kone
On March 18, 2013, 11:19 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9997/
> -----------------------------------------------------------
>
> (Updated March 18, 2013, 11:19 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp dadd06850565d07b46cea2f581661fb57a121118
> src/slave/slave.cpp 912499e4cb34afa9bcc1556fd9536581001933ca
> src/tests/gc_tests.cpp a9a7a439702ab87d5384c2d1b8afc0b17dab4e62
> src/tests/utils.hpp 50203579f1ea14ee751c12a373047e9295e4ebb3
>
> Diff: https://reviews.apache.org/r/9997/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>