You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oozie.apache.org by rk...@apache.org on 2013/02/04 19:03:13 UTC

svn commit: r1442258 - in /oozie/branches/branch-3.3: pom.xml release-log.txt src/main/resources/ src/main/resources/checkstyle-header.txt src/main/resources/checkstyle.xml

Author: rkanter
Date: Mon Feb  4 18:03:12 2013
New Revision: 1442258

URL: http://svn.apache.org/viewvc?rev=1442258&view=rev
Log:
OOZIE-1126 see if checkstyle works for oozie development. (jaoki via rkanter)

Added:
    oozie/branches/branch-3.3/src/main/resources/
    oozie/branches/branch-3.3/src/main/resources/checkstyle-header.txt
    oozie/branches/branch-3.3/src/main/resources/checkstyle.xml
Modified:
    oozie/branches/branch-3.3/pom.xml
    oozie/branches/branch-3.3/release-log.txt

Modified: oozie/branches/branch-3.3/pom.xml
URL: http://svn.apache.org/viewvc/oozie/branches/branch-3.3/pom.xml?rev=1442258&r1=1442257&r2=1442258&view=diff
==============================================================================
--- oozie/branches/branch-3.3/pom.xml (original)
+++ oozie/branches/branch-3.3/pom.xml Mon Feb  4 18:03:12 2013
@@ -756,6 +756,26 @@
                     <findbugsXmlWithMessages>true</findbugsXmlWithMessages>
                 </configuration>
             </plugin>
+
+            <!-- checkstyle plugin. Execute 'mvn verify' and look for checkstyle-result.xml under target folder -->
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <version>2.9.1</version>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                        <configuration>
+                            <consoleOutput>true</consoleOutput>
+                            <includeTestSourceDirectory>true</includeTestSourceDirectory>
+                            <configLocation>src/main/resources/checkstyle.xml</configLocation>
+                        </configuration>
+                    </execution>
+                </executions>
+            </plugin>
+
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-enforcer-plugin</artifactId>

Modified: oozie/branches/branch-3.3/release-log.txt
URL: http://svn.apache.org/viewvc/oozie/branches/branch-3.3/release-log.txt?rev=1442258&r1=1442257&r2=1442258&view=diff
==============================================================================
--- oozie/branches/branch-3.3/release-log.txt (original)
+++ oozie/branches/branch-3.3/release-log.txt Mon Feb  4 18:03:12 2013
@@ -1,5 +1,6 @@
 -- Oozie 3.3.2 (unreleased)
 
+OOZIE-1126 see if checkstyle works for oozie development. (jaoki via rkanter)
 OOZIE-1124 Split pig unit tests to a separate module (rohini via virag)
 OOZIE-1087 Remove requirement of hive-default.xml from Hive action (rkanter)
 OOZIE-1129 Add documentation for configurable filesystem support (rkanter)

Added: oozie/branches/branch-3.3/src/main/resources/checkstyle-header.txt
URL: http://svn.apache.org/viewvc/oozie/branches/branch-3.3/src/main/resources/checkstyle-header.txt?rev=1442258&view=auto
==============================================================================
--- oozie/branches/branch-3.3/src/main/resources/checkstyle-header.txt (added)
+++ oozie/branches/branch-3.3/src/main/resources/checkstyle-header.txt Mon Feb  4 18:03:12 2013
@@ -0,0 +1,18 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+*/
+

Added: oozie/branches/branch-3.3/src/main/resources/checkstyle.xml
URL: http://svn.apache.org/viewvc/oozie/branches/branch-3.3/src/main/resources/checkstyle.xml?rev=1442258&view=auto
==============================================================================
--- oozie/branches/branch-3.3/src/main/resources/checkstyle.xml (added)
+++ oozie/branches/branch-3.3/src/main/resources/checkstyle.xml Mon Feb  4 18:03:12 2013
@@ -0,0 +1,44 @@
+<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+
+<module name="Checker">
+
+	<module name="RegexpSingleline">
+		<property name="severity" value="warning"/>
+		<property name="format" value="\s+$"/>
+		<property name="message" value="Line has trailing spaces."/>
+	</module>
+
+	<module name="Header">
+		<property name="severity" value="warning"/>
+		<property name="headerFile" value="src/main/resources/checkstyle-header.txt"/>
+	</module>
+
+    <module name="TreeWalker">
+
+		<module name="LineLength">
+			<property name="severity" value="warning"/>
+			<property name="max" value="132"/>
+		</module>
+
+    </module>
+
+</module>
+