[GitHub] [hadoop] snvijaya commented on a diff in pull request #3335: HADOOP-17864. ABFS: Make provision for adding additional connections type

[GitBox <gi...@apache.org>]

snvijaya commented on code in PR #3335:
URL: https://github.com/apache/hadoop/pull/3335#discussion_r870775424


##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java:
##########
@@ -96,6 +97,17 @@ String getSasToken() {
     return sasToken;
   }
 
+  public ListResultSchema getListResultSchema()
+      throws AzureBlobFileSystemException {
+    if (result instanceof AbfsHttpConnection) {
+      return ((AbfsHttpConnection) this.result).getListResultSchema();
+    } else {
+      throw new AbfsRestOperationException(-1, null,

Review Comment:
   Result here is the response from store backend and List calls will only be supported HttpConnection. Is more of a safe guard check, though it can never get into else case. 
   If it does for any reason, we will want the workload to fail immediately highlighting the reason explicitly for easy debugging. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org