You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2010/01/27 16:32:34 UTC
[jira] Created: (MATH-335) Fraction.hashCode() inconsistent with
Fraction.equals()
Fraction.hashCode() inconsistent with Fraction.equals()
-------------------------------------------------------
Key: MATH-335
URL: https://issues.apache.org/jira/browse/MATH-335
Project: Commons Math
Issue Type: Bug
Reporter: Sebb
Priority: Minor
Fraction.hashCode() is inconsistent with Fraction.equals().
hashCode() uses getNumerator() (which is not final) rather than directly accessing the field.
Seems to me that hashCode() has no reason to use the getters - or if it does, then equals should do so too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-335) Fraction.hashCode() inconsistent with
Fraction.equals()
Posted by "Luc Maisonobe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805564#action_12805564 ]
Luc Maisonobe commented on MATH-335:
------------------------------------
Agreed. I would prefer it uses the fields directly.
> Fraction.hashCode() inconsistent with Fraction.equals()
> -------------------------------------------------------
>
> Key: MATH-335
> URL: https://issues.apache.org/jira/browse/MATH-335
> Project: Commons Math
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
>
> Fraction.hashCode() is inconsistent with Fraction.equals().
> hashCode() uses getNumerator() (which is not final) rather than directly accessing the field.
> Seems to me that hashCode() has no reason to use the getters - or if it does, then equals should do so too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MATH-335) Fraction.hashCode() inconsistent with
Fraction.equals()
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phil Steitz updated MATH-335:
-----------------------------
Fix Version/s: 2.1
> Fraction.hashCode() inconsistent with Fraction.equals()
> -------------------------------------------------------
>
> Key: MATH-335
> URL: https://issues.apache.org/jira/browse/MATH-335
> Project: Commons Math
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
> Fix For: 2.1
>
>
> Fraction.hashCode() is inconsistent with Fraction.equals().
> hashCode() uses getNumerator() (which is not final) rather than directly accessing the field.
> Seems to me that hashCode() has no reason to use the getters - or if it does, then equals should do so too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MATH-335) Fraction.hashCode() inconsistent with
Fraction.equals()
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved MATH-335.
-----------------------
Resolution: Fixed
URL: http://svn.apache.org/viewvc?rev=922715&view=rev
Log:
MATH-335 Fraction.hashCode() inconsistent with Fraction.equals()
Change hashCode() to use fields directly
> Fraction.hashCode() inconsistent with Fraction.equals()
> -------------------------------------------------------
>
> Key: MATH-335
> URL: https://issues.apache.org/jira/browse/MATH-335
> Project: Commons Math
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
> Fix For: 2.1
>
>
> Fraction.hashCode() is inconsistent with Fraction.equals().
> hashCode() uses getNumerator() (which is not final) rather than directly accessing the field.
> Seems to me that hashCode() has no reason to use the getters - or if it does, then equals should do so too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (MATH-335) Fraction.hashCode() inconsistent with
Fraction.equals()
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phil Steitz closed MATH-335.
----------------------------
> Fraction.hashCode() inconsistent with Fraction.equals()
> -------------------------------------------------------
>
> Key: MATH-335
> URL: https://issues.apache.org/jira/browse/MATH-335
> Project: Commons Math
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
> Fix For: 2.1
>
>
> Fraction.hashCode() is inconsistent with Fraction.equals().
> hashCode() uses getNumerator() (which is not final) rather than directly accessing the field.
> Seems to me that hashCode() has no reason to use the getters - or if it does, then equals should do so too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.