[jira] [Resolved] (SPARK-17955) Use the same read path in DataFrameReader.jdbc and DataFrameReader.format("jdbc")

["Reynold Xin (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-17955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Reynold Xin resolved SPARK-17955.
---------------------------------
       Resolution: Fixed
         Assignee: Hyukjin Kwon
    Fix Version/s: 2.1.0

> Use the same read path in DataFrameReader.jdbc and DataFrameReader.format("jdbc") 
> ----------------------------------------------------------------------------------
>
>                 Key: SPARK-17955
>                 URL: https://issues.apache.org/jira/browse/SPARK-17955
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Hyukjin Kwon
>            Assignee: Hyukjin Kwon
>            Priority: Trivial
>             Fix For: 2.1.0
>
>
> It seems APIs in {{DataFrameReader}}/{{DataFrameWriter}} share {{format("...").load()}} or {{format("...").save()}} APIs for {{json(...)}}/{{csv(...)}} and etc.
> We can share this within {{DataFrameReader.jdbc(...)}} too consistently with other APIs.
> {code}
> -    // connectionProperties should override settings in extraOptions.
> -    val params = extraOptions.toMap ++ connectionProperties.asScala.toMap
> -    val options = new JDBCOptions(url, table, params)
> -    val relation = JDBCRelation(parts, options)(sparkSession)
> -    sparkSession.baseRelationToDataFrame(relation)
> +    // connectionProperties should override settings in extraOptions
> +    this.extraOptions = this.extraOptions ++ (connectionProperties.asScala)
> +    // explicit url and dbtable should override all
> +    this.extraOptions += ("url" -> url, "dbtable" -> table)
> +    format("jdbc").load()
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org