You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/19 16:45:52 UTC

[GitHub] [camel-k] essobedo opened a new pull request, #3558: feat(cli): Allow to specify custom Kaniko and Buildah images

essobedo opened a new pull request, #3558:
URL: https://github.com/apache/camel-k/pull/3558

   fixes #3350 
   
   ## Motivation
   
   The docker images to use for Kaniko and Buildah are hard coded and should be configurable
   
   ## Modifications:
   
   * Add cli new parameters to provide the custom docker images (`kaniko-executor-image`, `kaniko-warmer-image`, and `buildah-image`)
   * Convert the default docker images into constants
   
   **Release Note**
   ```release-note
   Additional parameters have been added to specify custom Kaniko and Buildah images which are respectively 
   `kaniko-executor-image`, `kaniko-warmer-image`, and `buildah-image`
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi commented on pull request #3558: feat(cli): Allow to specify custom Kaniko and Buildah images

Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3558:
URL: https://github.com/apache/camel-k/pull/3558#issuecomment-1222099758

   Probably you should run `make generate` and update the CRDs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] essobedo commented on pull request #3558: feat(cli): Allow to specify custom Kaniko and Buildah images

Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #3558:
URL: https://github.com/apache/camel-k/pull/3558#issuecomment-1231601161

   Tests are failing because it cannot find Camel K Runtime 1.14.0 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi commented on pull request #3558: feat(cli): Allow to specify custom Kaniko and Buildah images

Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3558:
URL: https://github.com/apache/camel-k/pull/3558#issuecomment-1231420368

   You'd also need to run `make` after generating CRDs to update `pkg/resources/resources.go`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi commented on pull request #3558: feat(cli): Allow to specify custom Kaniko and Buildah images

Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3558:
URL: https://github.com/apache/camel-k/pull/3558#issuecomment-1221834845

   Buildah and Kaniko CI tests keep failing. Let's make sure it passes them before merging this pull req.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi merged pull request #3558: feat(cli): Allow to specify custom Kaniko and Buildah images

Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #3558:
URL: https://github.com/apache/camel-k/pull/3558


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] essobedo commented on pull request #3558: feat(cli): Allow to specify custom Kaniko and Buildah images

Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #3558:
URL: https://github.com/apache/camel-k/pull/3558#issuecomment-1231428551

   The command `make generate-deepcopy` has still no effect


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] essobedo commented on pull request #3558: feat(cli): Allow to specify custom Kaniko and Buildah images

Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #3558:
URL: https://github.com/apache/camel-k/pull/3558#issuecomment-1231442518

   > @essobedo Please see: https://camel.apache.org/camel-k/next/contributing/developers.html#requirements We ask macOS users to use gnu-sed instead.
   
   Thx for sharing, I installed gnu-sed already but my path was actually incorrect, it works well now, thx again 🙏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] essobedo commented on pull request #3558: feat(cli): Allow to specify custom Kaniko and Buildah images

Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #3558:
URL: https://github.com/apache/camel-k/pull/3558#issuecomment-1231427734

   > Probably you should run `make generate` and update the CRDs.
   
   FYI the command `make generate` fails on Mac OS (12.5.1) in ./script/gen_crd.sh with an error of type:
   ```
   ./script/gen_crd.sh
   sed: 1: "/creationTimestamp:/a\  ...": extra characters after \ at the end of a command
   make: *** [generate] Error 1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] essobedo commented on pull request #3558: feat(cli): Allow to specify custom Kaniko and Buildah images

Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #3558:
URL: https://github.com/apache/camel-k/pull/3558#issuecomment-1234103635

   The only test that fails is `TestNativeIntegrations/automatic_rollout_deployment_from_fast-jar_to_native_kit` which is a known failing test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] essobedo commented on pull request #3558: feat(cli): Allow to specify custom Kaniko and Buildah images

Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #3558:
URL: https://github.com/apache/camel-k/pull/3558#issuecomment-1222063959

   @tadayosi yes it is failing for an unknown reason. I don't know if it is related but the command `make generate-deepcopy` has no effect, any idea why?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi commented on pull request #3558: feat(cli): Allow to specify custom Kaniko and Buildah images

Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3558:
URL: https://github.com/apache/camel-k/pull/3558#issuecomment-1231432188

   @essobedo Please see:
   https://camel.apache.org/camel-k/next/contributing/developers.html#requirements
   We ask macOS users to use gnu-sed instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org