[PR] Fix SSL connection creation [iotdb-client-nodejs]

["HTHou (via GitHub)" <gi...@apache.org>]

HTHou opened a new pull request, #13:
URL: https://github.com/apache/iotdb-client-nodejs/pull/13

   ## Summary
   
   This fixes the SSL connection path so `enableSSL: true` creates a TLS socket with `thrift.createSSLConnection(...)` instead of a plain Thrift TCP connection.
   
   ## Root Cause
   
   The previous `enableSSL` branch still called `thrift.createConnection(...)`. For IoTDB's raw Thrift RPC port, that sends plaintext bytes to an SSL-enabled server, so a server configured with `enable_thrift_ssl=true` rejects the connection before the session can open.
   
   ## Changes
   
   - Use `thrift.createSSLConnection(...)` when `enableSSL` is true.
   - Keep the non-SSL path on `thrift.createConnection(...)`.
   - Add unit tests to verify the SSL and non-SSL connection factories selected by `Connection.open()`.
   
   ## Validation
   
   - `npm test -- --runInBand tests/unit/Connection.test.ts`
   - `npm run test:unit`
   - `npm run build`
   
   `npm run lint` currently fails on existing repository-wide lint issues in benchmark/examples/e2e and pre-existing source files; this PR does not add new lint failures in the changed unit test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix SSL connection creation [iotdb-client-nodejs]

["CritasWang (via GitHub)" <gi...@apache.org>]

CritasWang merged PR #13:
URL: https://github.com/apache/iotdb-client-nodejs/pull/13


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org