You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/12/06 03:59:36 UTC

[kudu-CR] java: add unit test for RetryRule 

Hello Adar Dembo, Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/12041

to review the following change.


Change subject: java: add unit test for RetryRule
......................................................................

java: add unit test for RetryRule

Also some minor refactoring of the RetryRule

Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
A java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java
2 files changed, 47 insertions(+), 17 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/12041/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
Gerrit-Change-Number: 12041
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] java: add unit test for RetryRule

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12041 )

Change subject: java: add unit test for RetryRule
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java:

http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java@40
PS1, Line 40:   public RetryRule () {
> Nit: RetryRule()
Done


http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java@45
PS1, Line 45:   protected RetryRule(int retryCount) {
> Package private is stricter and sufficient, I think.
Done


http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java@71
PS1, Line 71:         ++attempt;
> nit: I think attempt++ makes the most sense here given there is no need to 
Done


http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java
File java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java:

PS1: 
> License header.
Done


http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java@10
PS1, Line 10:   private int failures = 0;
> nit: put this inside the test method.
can't do that ... this controls when the test stops failing. I'll add a comment.


http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java@21
PS1, Line 21:       assertFalse("" + failures + " failures", true);
> Maybe use String.format()? "" + ... is a little weird.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
Gerrit-Change-Number: 12041
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 06 Dec 2018 18:52:32 +0000
Gerrit-HasComments: Yes

[kudu-CR] java: add unit test for RetryRule

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12041 )

Change subject: java: add unit test for RetryRule
......................................................................


Patch Set 3: Code-Review+2

Not sure why TestSecurity failed three times, but the code looks good.


-- 
To view, visit http://gerrit.cloudera.org:8080/12041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
Gerrit-Change-Number: 12041
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 07 Dec 2018 17:58:13 +0000
Gerrit-HasComments: No

[kudu-CR] java: add unit test for RetryRule

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12041 )

Change subject: java: add unit test for RetryRule
......................................................................


Patch Set 3: Verified+1

Same here, let's merge this anyway


-- 
To view, visit http://gerrit.cloudera.org:8080/12041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
Gerrit-Change-Number: 12041
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 07 Dec 2018 22:41:20 +0000
Gerrit-HasComments: No

[kudu-CR] java: add unit test for RetryRule

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12041 )

Change subject: java: add unit test for RetryRule
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java
File java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java:

http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java@8
PS1, Line 8: public class TestRetryRule {
In a future patch, should this test manually disable reporting? Otherwise it will always be on the dashboard with a 66% failure rate.



-- 
To view, visit http://gerrit.cloudera.org:8080/12041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
Gerrit-Change-Number: 12041
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 06 Dec 2018 18:54:46 +0000
Gerrit-HasComments: Yes

[kudu-CR] java: add unit test for RetryRule

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12041

to look at the new patch set (#2).

Change subject: java: add unit test for RetryRule
......................................................................

java: add unit test for RetryRule

Also did some minor refactoring of the RetryRule.

Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
A java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java
2 files changed, 63 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/12041/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
Gerrit-Change-Number: 12041
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] java: add unit test for RetryRule

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12041 )

Change subject: java: add unit test for RetryRule
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java:

http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java@40
PS1, Line 40:   public RetryRule () {
Nit: RetryRule()


http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java@45
PS1, Line 45:   protected RetryRule(int retryCount) {
Package private is stricter and sufficient, I think.


http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java
File java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java:

PS1: 
License header.


http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java@21
PS1, Line 21:       assertFalse("" + failures + " failures", true);
Maybe use String.format()? "" + ... is a little weird.



-- 
To view, visit http://gerrit.cloudera.org:8080/12041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
Gerrit-Change-Number: 12041
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 06 Dec 2018 18:18:12 +0000
Gerrit-HasComments: Yes

[kudu-CR] java: add unit test for RetryRule

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12041 )

Change subject: java: add unit test for RetryRule
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java
File java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java:

http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java@8
PS1, Line 8: //
> In a future patch, should this test manually disable reporting? Otherwise i
Yep, I've got a patch at the end of this series that does that.



-- 
To view, visit http://gerrit.cloudera.org:8080/12041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
Gerrit-Change-Number: 12041
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 07 Dec 2018 02:47:17 +0000
Gerrit-HasComments: Yes

[kudu-CR] java: add unit test for RetryRule

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has removed a vote on this change.

Change subject: java: add unit test for RetryRule
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/12041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
Gerrit-Change-Number: 12041
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] java: add unit test for RetryRule

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12041 )

Change subject: java: add unit test for RetryRule
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java:

http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java@71
PS1, Line 71:         ++attempt;
nit: I think attempt++ makes the most sense here given there is no need to return the original attempt value before incrementing.


http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java
File java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java:

http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java@10
PS1, Line 10:   private int failures = 0;
nit: put this inside the test method.



-- 
To view, visit http://gerrit.cloudera.org:8080/12041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
Gerrit-Change-Number: 12041
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 06 Dec 2018 15:14:39 +0000
Gerrit-HasComments: Yes

[kudu-CR] java: add unit test for RetryRule

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12041

to look at the new patch set (#3).

Change subject: java: add unit test for RetryRule
......................................................................

java: add unit test for RetryRule

Also did some minor refactoring of the RetryRule.

Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
A java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java
2 files changed, 67 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/12041/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
Gerrit-Change-Number: 12041
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] java: add unit test for RetryRule

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12041 )

Change subject: java: add unit test for RetryRule
......................................................................


Patch Set 1: Verified+1

Overriding a flake in WriteThrottlingTest.ThrottleWriteRpcPerSec:

Error Message
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/write_throttling-itest.cc:109
Expected: (qps) <= (TARGET_QPS * 1.2f), actual: 120.711 vs 120


-- 
To view, visit http://gerrit.cloudera.org:8080/12041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
Gerrit-Change-Number: 12041
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 06 Dec 2018 08:54:14 +0000
Gerrit-HasComments: No

[kudu-CR] java: add unit test for RetryRule

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12041 )

Change subject: java: add unit test for RetryRule
......................................................................

java: add unit test for RetryRule

Also did some minor refactoring of the RetryRule.

Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
Reviewed-on: http://gerrit.cloudera.org:8080/12041
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Mike Percy <mp...@apache.org>
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
A java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java
2 files changed, 67 insertions(+), 17 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Mike Percy: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
Gerrit-Change-Number: 12041
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] java: add unit test for RetryRule

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has removed a vote on this change.

Change subject: java: add unit test for RetryRule
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/12041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021
Gerrit-Change-Number: 12041
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>