[jira] [Commented] (FLINK-5698) Add NestedFieldsProjectableTableSource interface

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853939#comment-15853939 ] 

ASF GitHub Bot commented on FLINK-5698:
---------------------------------------

GitHub user tonycox opened a pull request:

    https://github.com/apache/flink/pull/3269

    [FLINK-5698] Add NestedFieldsProjectableTableSource trait

    - add extraction of RexFieldAccess method
    - complete PushProjectIntoBatchTableSourceScanRule with new interface
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    Should we test the NestedFieldsProjectableTableSource in unit test?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tonycox/flink nestingTableSource

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3269
    
----
commit fa8b9f2b62066c832bd36e17db4499c875d2d25f
Author: tonycox <an...@epam.com>
Date:   2017-02-06T12:32:45Z

    [FLINK-5698] Add NestedFieldsProjectableTableSource trait
    
    - add extraction of RexFieldAccess method
    - complete PushProjectIntoBatchTableSourceScanRule with new interface

----


> Add NestedFieldsProjectableTableSource interface
> ------------------------------------------------
>
>                 Key: FLINK-5698
>                 URL: https://issues.apache.org/jira/browse/FLINK-5698
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Anton Solovev
>            Assignee: Anton Solovev
>
> Add a NestedFieldsProjectableTableSource interface for some TableSource implementation that support nesting projection push-down.
> The interface could look as follows
> {code}
> def trait NestedFieldsProjectableTableSource {
>   def projectNestedFields(fields: Array[String]): NestedFieldsProjectableTableSource[T]
> }
> {code}
> This interface works together with ProjectableTableSource 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)