You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/05/02 03:39:00 UTC

Review Request 33772: Update widgets.json and metrics.json files

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33772/
-----------------------------------------------------------

Review request for Ambari, Xi Wang and Yusaku Sako.


Bugs: AMBARI-10893
    https://issues.apache.org/jira/browse/AMBARI-10893


Repository: ambari


Description
-------

This patch does following:
1. Upadtes widgets.json and metrics.json to show more intuitive and meaningful widgets on service dashboards for HDFS, YARN and HBase.
2. Resolves an issue where an expression for a Graph resulting in a datapoint with value "NaN" (0/0) at some point threw JS error from RickShaw li brary
3. Enables the experimental flag for Enhanced dahboard feature.


Diffs
-----

  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json 949f273 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metrics.json a96d45c 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 5e910ae 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metrics.json dc7dcbd 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json 6b62b80 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/widgets.json 2f92e15 
  ambari-web/app/config.js 440a1ea 
  ambari-web/app/views/common/widget/graph_widget_view.js e6d854e 

Diff: https://reviews.apache.org/r/33772/diff/


Testing
-------

Tesetd the patch on a cluster.
All existing unit tests passesswith the patch:


  5970 tests complete (10 seconds)
  79 tests pending


Thanks,

Jaimin Jetly


Re: Review Request 33772: Update widgets.json and metrics.json files

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33772/#review82307
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On May 2, 2015, 1:38 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33772/
> -----------------------------------------------------------
> 
> (Updated May 2, 2015, 1:38 a.m.)
> 
> 
> Review request for Ambari, Xi Wang and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10893
>     https://issues.apache.org/jira/browse/AMBARI-10893
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch does following:
> 1. Upadtes widgets.json and metrics.json to show more intuitive and meaningful widgets on service dashboards for HDFS, YARN and HBase.
> 2. Resolves an issue where an expression for a Graph resulting in a datapoint with value "NaN" (0/0) at some point threw JS error from RickShaw li brary
> 3. Enables the experimental flag for Enhanced dahboard feature.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json 949f273 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metrics.json a96d45c 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 5e910ae 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metrics.json dc7dcbd 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json 6b62b80 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/widgets.json 2f92e15 
>   ambari-web/app/config.js 440a1ea 
>   ambari-web/app/views/common/widget/graph_widget_view.js e6d854e 
> 
> Diff: https://reviews.apache.org/r/33772/diff/
> 
> 
> Testing
> -------
> 
> Tesetd the patch on a cluster.
> All existing unit tests passesswith the patch:
> 
> 
>   5970 tests complete (10 seconds)
>   79 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>