[GitHub] [ozone] ChenSammi commented on a diff in pull request #3875: HDDS-7183. Expose RocksDB critical properties.

["ChenSammi (via GitHub)" <gi...@apache.org>]

ChenSammi commented on code in PR #3875:
URL: https://github.com/apache/ozone/pull/3875#discussion_r1116596235


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/RocksDBStoreMBean.java:
##########
@@ -179,6 +234,7 @@ public void getMetrics(MetricsCollector metricsCollector, boolean b) {
     MetricsRecordBuilder rb = metricsCollector.addRecord(contextName);
     getHistogramData(rb);
     getTickerTypeData(rb);
+    getDBPropertyData(rb);

Review Comment:
   @symious ,  some newly added metrics, for example "estimate-pending-compaction-bytes". If the value is too high, it 's a warning message. To find out why there are so many pending compaction bytes, we need to look into other rocksdb metrics, which are exposed by HistogramData and TickerTypeData.  
   
   So although the newly added properties in patch doesn't depend on rocksdb.statistics turn on, but in a real problem investigation, all these three types of metrics information are all needed. So rocksdb.statistics controls all metrics display is a fair solution. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org