You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/08/20 19:12:37 UTC

[GitHub] [commons-lang] arturobernalg opened a new pull request, #939: Rename method and fix typo.

arturobernalg opened a new pull request, #939:
URL: https://github.com/apache/commons-lang/pull/939

   NOTEL: Broke binary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #939: Rename method and fix typo.

Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #939:
URL: https://github.com/apache/commons-lang/pull/939#issuecomment-1221393311

   Is this a duplicate PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] arturobernalg commented on pull request #939: Rename method and fix typo.

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on PR #939:
URL: https://github.com/apache/commons-lang/pull/939#issuecomment-1221551965

   > Is this PR a duplicate?
   
   Yes. Similar to https://github.com/apache/commons-lang/pull/940 but without binary compatibility. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] codecov-commenter commented on pull request #939: Rename method and fix typo.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #939:
URL: https://github.com/apache/commons-lang/pull/939#issuecomment-1221389672

   # [Codecov](https://codecov.io/gh/apache/commons-lang/pull/939?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#939](https://codecov.io/gh/apache/commons-lang/pull/939?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b160500) into [master](https://codecov.io/gh/apache/commons-lang/commit/ef68684cb3d49888a0b8a7c94699afb9c56f63d3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ef68684) will **not change** coverage.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #939   +/-   ##
   =========================================
     Coverage     92.01%   92.01%           
     Complexity     7435     7435           
   =========================================
     Files           189      189           
     Lines         15751    15751           
     Branches       2961     2961           
   =========================================
     Hits          14493    14493           
     Misses          672      672           
     Partials        586      586           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/commons-lang/pull/939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...a/org/apache/commons/lang3/time/DurationUtils.java](https://codecov.io/gh/apache/commons-lang/pull/939/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvdGltZS9EdXJhdGlvblV0aWxzLmphdmE=) | `84.61% <100.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] arturobernalg commented on pull request #939: Rename method and fix typo.

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on PR #939:
URL: https://github.com/apache/commons-lang/pull/939#issuecomment-1221578920

   close in favor of  `[940](https://github.com/apache/commons-lang/pull/940)`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] arturobernalg closed pull request #939: Rename method and fix typo.

Posted by GitBox <gi...@apache.org>.
arturobernalg closed pull request #939: Rename method and fix typo.
URL: https://github.com/apache/commons-lang/pull/939


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #939: Rename method and fix typo.

Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #939:
URL: https://github.com/apache/commons-lang/pull/939#issuecomment-1221540207

   Is this PR a duplicate?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org