You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/22 03:05:02 UTC

[GitHub] [airflow] darwinyip commented on a change in pull request #9887: Add typing to ImapHook

darwinyip commented on a change in pull request #9887:
URL: https://github.com/apache/airflow/pull/9887#discussion_r458506313



##########
File path: airflow/providers/imap/hooks/imap.py
##########
@@ -41,7 +42,7 @@ class ImapHook(BaseHook):
     :type imap_conn_id: str
     """
 
-    def __init__(self, imap_conn_id='imap_default'):
+    def __init__(self, imap_conn_id: str = 'imap_default') -> None:
         super().__init__()
         self.imap_conn_id = imap_conn_id
         self.mail_client = None

Review comment:
       This still gives the same mypy errors.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org