You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by GitBox <gi...@apache.org> on 2021/01/11 10:53:17 UTC
[GitHub] [metamodel] arjansh opened a new pull request #247: Build on Travis fails most of the time
arjansh opened a new pull request #247:
URL: https://github.com/apache/metamodel/pull/247
Fixes https://issues.apache.org/jira/browse/METAMODEL-1232.
- I refactored the `ExcelDataContextTest` from using JUnit 3 to JUnit 4, so it can use the ` TemporaryFolder` rule for copying files when using them it tests. It seems this works better than when copying them to the target folder.
- I refactored the logic used by `ElasticSearchUtils#createRow(...)` for creating a row based on a MAP column type. It uses `computeIfAbsent` to put a `HashMap` in a `Map`, but then within the method that created that `HashMap`, it would already add the created `HashMap` to the `Map`, which is something that should be handled by the `computeIfAbsent` itself, which apparently can lead to `ConcurrentModificationExpection`s being thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [metamodel] arjansh commented on pull request #247: Build on Travis fails most of the time
Posted by GitBox <gi...@apache.org>.
arjansh commented on pull request #247:
URL: https://github.com/apache/metamodel/pull/247#issuecomment-780389224
@kaspersorensen Can you maybe look at my reply to your comment? And if it satisfies you maybe merge this Pull Request?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [metamodel] arjansh commented on a change in pull request #247: Build on Travis fails most of the time
Posted by GitBox <gi...@apache.org>.
arjansh commented on a change in pull request #247:
URL: https://github.com/apache/metamodel/pull/247#discussion_r557147254
##########
File path: excel/src/test/java/org/apache/metamodel/excel/ExcelDataContextTest.java
##########
@@ -928,14 +970,15 @@ public void testInsertingValueOfValidColumnType() {
assertTrue(dataSet.next());
}
- @Test(expected = MetaModelException.class)
+ @Test
Review comment:
It never threw an exception. Because we were using JUnit3 the expected exception part of the annotation was ignored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [metamodel] arjansh commented on pull request #247: Build on Travis fails most of the time
Posted by GitBox <gi...@apache.org>.
arjansh commented on pull request #247:
URL: https://github.com/apache/metamodel/pull/247#issuecomment-799166421
@kaspersorensen Can you maybe give this pull request another look. It should make the build more stable so we don't get failing unit tests in all pull requests which are unrelated to these pull requests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [metamodel] kaspersorensen commented on a change in pull request #247: Build on Travis fails most of the time
Posted by GitBox <gi...@apache.org>.
kaspersorensen commented on a change in pull request #247:
URL: https://github.com/apache/metamodel/pull/247#discussion_r555182429
##########
File path: excel/src/test/java/org/apache/metamodel/excel/ExcelDataContextTest.java
##########
@@ -928,14 +970,15 @@ public void testInsertingValueOfValidColumnType() {
assertTrue(dataSet.next());
}
- @Test(expected = MetaModelException.class)
+ @Test
Review comment:
Why does this no longer throw the exception? Do we want it not to?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [metamodel] kaspersorensen commented on pull request #247: Build on Travis fails most of the time
Posted by GitBox <gi...@apache.org>.
kaspersorensen commented on pull request #247:
URL: https://github.com/apache/metamodel/pull/247#issuecomment-799221240
Thanks for the nudge Arjan! Yes this looks good to me then!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [metamodel] asfgit merged pull request #247: Build on Travis fails most of the time
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #247:
URL: https://github.com/apache/metamodel/pull/247
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org