[jira] [Resolved] (CALCITE-2954) SubQueryJoinRemoveRule and SubQueryProjectRemoveRule passing on empty set instead of set of correlation id

["Haisheng Yuan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Haisheng Yuan resolved CALCITE-2954.
------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.20.0

Pushed to master, thanks, [~vgarg]!

> SubQueryJoinRemoveRule and SubQueryProjectRemoveRule passing on empty set instead of set of correlation id
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-2954
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2954
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Vineet Garg
>            Assignee: Vineet Garg
>            Priority: Major
>              Labels: pull-request-available, sub-query
>             Fix For: 1.20.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Call to {{apply}} takes set of {{CorrelationId}} but both {{SubQueryJoinRemoveRule}} and {{SubQueryProjectRemoveRule}} are passing empty set for whatever reason.
> I believe the correct thing to do here is to pass on the actual set of {{CorrelationId}} like {{SubQueryFilterRemoveRule}}
> Ref:
> {code:java}
> final RexNode target = apply(e, ImmutableSet.of(),
>     logic, builder, 2, fieldCount);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)