You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/09/08 19:00:35 UTC
[GitHub] [hbase] saintstack commented on a change in pull request #2361: HBASE-24995: MetaFixer fails to fix overlaps when multiple tables hav…
saintstack commented on a change in pull request #2361:
URL: https://github.com/apache/hbase/pull/2361#discussion_r485131713
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java
##########
@@ -231,16 +235,18 @@ private static RegionInfo buildRegionInfo(TableName tn, byte [] start, byte [] e
/**
* Fix overlaps noted in CJ consistency report.
*/
- void fixOverlaps(CatalogJanitor.Report report) throws IOException {
+ List<Long> fixOverlaps(CatalogJanitor.Report report) throws IOException {
+ List<Long> pidList = new ArrayList<>();
Review comment:
This change is just to make your fix more testable? If so, that is fine. I wasn't expecting it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org