You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2016/02/03 01:15:23 UTC

Review Request 43122: Updated Rakefile to automatically generate doxygen pages.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43122/
-----------------------------------------------------------

Review request for mesos, Joseph Wu and Neil Conway.


Bugs: MESOS-4584
    https://issues.apache.org/jira/browse/MESOS-4584


Repository: mesos


Description
-------

See summary.


Diffs
-----

  site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 

Diff: https://reviews.apache.org/r/43122/diff/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43122/#review118120
-----------------------------------------------------------



Hm.. a bit tough to tell what this change is about, mind elaborating in the description?

- Ben Mahler


On Feb. 5, 2016, 9:19 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43122/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 9:19 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Neil Conway.
> 
> 
> Bugs: MESOS-4584
>     https://issues.apache.org/jira/browse/MESOS-4584
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 
> 
> Diff: https://reviews.apache.org/r/43122/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43122/
-----------------------------------------------------------

(Updated Feb. 9, 2016, 6:22 p.m.)


Review request for mesos, Joseph Wu and Neil Conway.


Changes
-------

rebased


Bugs: MESOS-4584
    https://issues.apache.org/jira/browse/MESOS-4584


Repository: mesos


Description
-------

There are three components to generating new doxygen pages:

1. Now that we have a Doxyfile, pass it to `doxygen` command.
2. Genarate doxygen pages in a diretcory named `doxygen` in the current
   directory.
3. Once the doxygen pages have been generated, move them into
   `publish/api/latest/c++`.

After step 3, one can copy over the publish directory to mesos-site svn
repository.


Diffs (updated)
-----

  site/Rakefile 10817d42eb572aa6e250a2d2fad9f3b385839f8b 

Diff: https://reviews.apache.org/r/43122/diff/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43122/
-----------------------------------------------------------

(Updated Feb. 9, 2016, 6:13 p.m.)


Review request for mesos, Joseph Wu and Neil Conway.


Changes
-------

minor.


Bugs: MESOS-4584
    https://issues.apache.org/jira/browse/MESOS-4584


Repository: mesos


Description (updated)
-------

There are three components to generating new doxygen pages:

1. Now that we have a Doxyfile, pass it to `doxygen` command.
2. Genarate doxygen pages in a diretcory named `doxygen` in the current
   directory.
3. Once the doxygen pages have been generated, move them into
   `publish/api/latest/c++`.

After step 3, one can copy over the publish directory to mesos-site svn
repository.


Diffs (updated)
-----

  site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 

Diff: https://reviews.apache.org/r/43122/diff/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43122/
-----------------------------------------------------------

(Updated Feb. 9, 2016, 3:55 p.m.)


Review request for mesos, Joseph Wu and Neil Conway.


Changes
-------

Updated Rakefile to create publish/api/latest if not already present.


Bugs: MESOS-4584
    https://issues.apache.org/jira/browse/MESOS-4584


Repository: mesos


Description (updated)
-------

There are three components to generating new doxygen pages:

1. Now that we have a Doxyfile, pass it to `doxygen` command.
2. Genarate doxygen pages in a diretcory named `doxygen` in the current
   directory.
3. Once the doxygen pages have been generated, move them into
   `publish/api/latest/c++`.

After step 3, one can copy over the publish directory to mesos-site svn
repository.


Diffs
-----

  site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 

Diff: https://reviews.apache.org/r/43122/diff/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43122/
-----------------------------------------------------------

(Updated Feb. 9, 2016, 3:54 p.m.)


Review request for mesos, Joseph Wu and Neil Conway.


Bugs: MESOS-4584
    https://issues.apache.org/jira/browse/MESOS-4584


Repository: mesos


Description (updated)
-------

There are three components to generating new doxygen pages:

1. Now that we have a Doxyfile, pass it to `doxygen` command.
2. Genarate doxygen pages in a diretcory named `doxygen` in the current
   directory.
3. Once the doxygen pages have been generated, move them into
   `publish/api/latest/c++`.

After step 3, one can copy over the publish directory to mesos-site svn
repository.


Diffs (updated)
-----

  site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 

Diff: https://reviews.apache.org/r/43122/diff/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43122/#review118185
-----------------------------------------------------------


Ship it!




Ship It!

- Ben Mahler


On Feb. 6, 2016, 11:30 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43122/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2016, 11:30 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Neil Conway.
> 
> 
> Bugs: MESOS-4584
>     https://issues.apache.org/jira/browse/MESOS-4584
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There are three components to generating new doxygen pages:
> 
> 1. Now that we have a Doxyfile, pass it to `doxygen` command.
> 2. Genarate doxygen pages in a diretcory named `doxygen` in the current directory.
> 3. Once the doxygen pages have been generated, move them into `publish/api/latest/c++`.
> 
> After step 3, one can copy over the publish directory to mesos-site svn repository.
> 
> 
> Diffs
> -----
> 
>   site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 
> 
> Diff: https://reviews.apache.org/r/43122/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43122/
-----------------------------------------------------------

(Updated Feb. 6, 2016, 6:30 p.m.)


Review request for mesos, Joseph Wu and Neil Conway.


Bugs: MESOS-4584
    https://issues.apache.org/jira/browse/MESOS-4584


Repository: mesos


Description (updated)
-------

There are three components to generating new doxygen pages:

1. Now that we have a Doxyfile, pass it to `doxygen` command.
2. Genarate doxygen pages in a diretcory named `doxygen` in the current directory.
3. Once the doxygen pages have been generated, move them into `publish/api/latest/c++`.

After step 3, one can copy over the publish directory to mesos-site svn repository.


Diffs
-----

  site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 

Diff: https://reviews.apache.org/r/43122/diff/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43122/
-----------------------------------------------------------

(Updated Feb. 5, 2016, 4:19 p.m.)


Review request for mesos, Joseph Wu and Neil Conway.


Summary (updated)
-----------------

Updated doxygen target for site/Rakefile.


Bugs: MESOS-4584
    https://issues.apache.org/jira/browse/MESOS-4584


Repository: mesos


Description (updated)
-------

See summary


Diffs (updated)
-----

  site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 

Diff: https://reviews.apache.org/r/43122/diff/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 43122: Updated Rakefile to automatically generate doxygen pages.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43122/#review117559
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43120, 43121, 43122]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 3, 2016, 12:15 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43122/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 12:15 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Neil Conway.
> 
> 
> Bugs: MESOS-4584
>     https://issues.apache.org/jira/browse/MESOS-4584
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 
> 
> Diff: https://reviews.apache.org/r/43122/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>