[jira] [Commented] (MAPREDUCE-5769) Unregistration to RM should not be called if AM is crashed before registering with RM

["Rohith (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919007#comment-13919007 ] 

Rohith commented on MAPREDUCE-5769:
-----------------------------------

Please find more information on patch.
bq. TestJobEndNotifier is not an appropriate place for these tests as they have nothing to do with job end notification
       I added test case in TestRMContainerAllocator. Is it okay?

bq. The test should setup an appropriately mocked scheduler member and call the real register() and unregister() methods to verify that the mocked scheduler sees unregistration when it should and not when it shouldn't
Fixed, test case check for isApplicationMasterRegistered. If we remove this flag from register(), test case will fail.

bq. isApplicationMasterRegistered should not be exposed via get/set methods and probably doesn't need to be volatile.
Fixed. For testing purpose, added protected method isApplicationMasterRegistered().

> Unregistration to RM should not be called if AM is crashed before registering with RM
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5769
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5769
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Rohith
>            Assignee: Rohith
>         Attachments: MAPREDUCE-5769.1.patch, MAPREDUCE-5769.2.patch
>
>
> Got the scenario from YARN-1752, where unregistration of application master is called before registering with RM.
> There should be mechanism to identify isApplicationMasaterRegistered before calling unregistration (finishApplicationMaster).



--
This message was sent by Atlassian JIRA
(v6.2#6252)