[jira] [Commented] (SOLR-6899) SolrJ CollectionAdminRequest classes should not support public setters for action

["Anshum Gupta (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260582#comment-14260582 ] 

Anshum Gupta commented on SOLR-6899:
------------------------------------

Changed the description for this change to be just limited to 'action' as CollectionAdminRequest extends SolrRequest which has public path/method methods.

> SolrJ CollectionAdminRequest classes should not support public setters for action
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-6899
>                 URL: https://issues.apache.org/jira/browse/SOLR-6899
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Anshum Gupta
>            Assignee: Anshum Gupta
>
> There shouldn't be public action setters for the CollectionAdminRequests.
> To elaborate more, a Create object should be able to do just that, doesn't make sense to support/have the following:
> {code}
> Create c = new Create();
> c.setAction("RELOAD");
> {code}
> The implementation could have an action = <custom action> in case of custom actions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org