You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/20 15:17:03 UTC

[GitHub] [spark] awdavidson commented on pull request #35913: [SPARK-38604][SQL] Keep ceil and floor with only a single argument the same as before

awdavidson commented on pull request #35913:
URL: https://github.com/apache/spark/pull/35913#issuecomment-1073272974


   @revans2 I think it would be wise to add tests part of this PR to prevent the same issue being re-introduced? I guess it would make sense to add them in the same place as the commit changing the functionality https://github.com/apache/spark/commit/62421455e552b892d6e4f908d55a5886b37a37a9 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org