You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/08 05:03:12 UTC

[GitHub] [spark] sharkdtu commented on a diff in pull request #38518: [SPARK-33349][K8S] Reset the executor pods watcher when we receive a version changed from k8s

sharkdtu commented on code in PR #38518:
URL: https://github.com/apache/spark/pull/38518#discussion_r1042926171


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsWatchSnapshotSource.scala:
##########
@@ -78,6 +80,15 @@ class ExecutorPodsWatchSnapshotSource(
     }
   }
 
+  def reset(watcher: ExecutorPodsWatcher): Unit = {

Review Comment:
   Have you ever test it?
   The problem is that kubernetes client has been closed. reset may throw an exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org