[jira] [Commented] (DL-23) Move distributedlog build to depend on central maven repo

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DL-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625052#comment-15625052 ] 

ASF GitHub Bot commented on DL-23:
----------------------------------

Github user sijie commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/27
  
    @jiazhai it would good that you can send out the second part of this change. I took a look at this change initially. the layout seems to be fine. I would like to see how will you change the server side and decide later on. /cc @leighst 
    
    also, this change is touching quite bunch of files. it will definitely conflict with the repackaging change made by @khurrumnasimm . so we'd coordinate on merging them.


> Move distributedlog build to depend on central maven repo
> ---------------------------------------------------------
>
>                 Key: DL-23
>                 URL: https://issues.apache.org/jira/browse/DL-23
>             Project: DistributedLog
>          Issue Type: Improvement
>          Components: distributedlog-client, distributedlog-core
>            Reporter: Sijie Guo
>
> Reported https://github.com/twitter/distributedlog/issues/37.
> Currently they are a few dependencies only exists at maven.twttr. There are two major pieces, one is the finagle-serverset and while the other one is thrift library. The finagle-serverset is majorly used for service-discovery by distributedlog-client and thrift is used by scrooge and the rpc wire protocol between client and write proxy.
> There are two options:
> - one is to look for a solution to move those dependencies to central maven repo.
> - the other one is to see if we can make thrift and its service discovery pluginnable. so we can support both finagle-thrift and gRPC-protobuf. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)