You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "pnowojski (via GitHub)" <gi...@apache.org> on 2023/03/31 08:15:51 UTC

[GitHub] [flink] pnowojski commented on a diff in pull request #22313: [FLINK-31660][connector-kafka] fix kafka connector pom so ITCases run in IDE

pnowojski commented on code in PR #22313:
URL: https://github.com/apache/flink/pull/22313#discussion_r1154162779


##########
flink-connectors/flink-connector-kafka/pom.xml:
##########
@@ -68,6 +67,20 @@ under the License.
 			<optional>true</optional>
 		</dependency>
 
+		<dependency>
+			<groupId>org.apache.flink</groupId>
+			<artifactId>flink-table-runtime</artifactId>
+			<version>${project.version}</version>
+			<scope>provided</scope>
+		</dependency>
+
+		<dependency>
+			<groupId>org.apache.flink</groupId>
+			<artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+			<version>${project.version}</version>
+			<scope>provided</scope>
+		</dependency>
+

Review Comment:
   Those also should be `optional` (we don't want to force `DataStream API` users to depend on `flink-table-xxx` packages)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org