You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/11/16 09:57:20 UTC
[GitHub] [phoenix] litianmei opened a new pull request #969: Phoenix 6223 could not find or load main class sqline.SqLine
litianmei opened a new pull request #969:
URL: https://github.com/apache/phoenix/pull/969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #969: Phoenix 6223 could not find or load main class sqline.SqLine
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #969:
URL: https://github.com/apache/phoenix/pull/969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #969: Phoenix 6223 could not find or load main class sqline.SqLine
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #969:
URL: https://github.com/apache/phoenix/pull/969#discussion_r525038798
##########
File path: bin/phoenix_utils.py
##########
@@ -77,7 +77,7 @@ def findClasspath(command_name):
return tryDecode(subprocess.Popen(command, shell=True, stdout=subprocess.PIPE).stdout.read())
def setPath():
- PHOENIX_CLIENT_JAR_PATTERN = "phoenix-client.jar"
+ PHOENIX_CLIENT_JAR_PATTERN = "phoenix-client*[!s][!t].jar"
Review comment:
This will still match sources:
ls -l phoenix-client*[!s][!t].jar
-rw-r--r-- 1 stoty staff 75651719 Nov 17 11:04 phoenix-client-5.1.0-SNAPSHOT-sources.jar
-rw-r--r-- 1 stoty staff 144017266 Nov 17 11:04 phoenix-client-5.1.0-SNAPSHOT.jar
This would not:
[stoty@IstvanToth-MBP15:~/workspaces/apache-phoenix/phoenix/phoenix-client-parent/phoenix-client/target (master)$]ls -l phoenix-client*[!s].jar
-rw-r--r-- 1 stoty staff 144017266 Nov 17 11:04 phoenix-client-5.1.0-SNAPSHOT.jar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] litianmei commented on a change in pull request #969: Phoenix 6223 could not find or load main class sqline.SqLine
Posted by GitBox <gi...@apache.org>.
litianmei commented on a change in pull request #969:
URL: https://github.com/apache/phoenix/pull/969#discussion_r531414411
##########
File path: bin/phoenix_utils.py
##########
@@ -77,7 +77,7 @@ def findClasspath(command_name):
return tryDecode(subprocess.Popen(command, shell=True, stdout=subprocess.PIPE).stdout.read())
def setPath():
- PHOENIX_CLIENT_JAR_PATTERN = "phoenix-client.jar"
+ PHOENIX_CLIENT_JAR_PATTERN = "phoenix-client*[!s][!t].jar"
Review comment:
I have modified it，please have a look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #969: Phoenix 6223 could not find or load main class sqline.SqLine
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #969:
URL: https://github.com/apache/phoenix/pull/969#issuecomment-727871574
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | pylint | 0m 5s | There were no new pylint issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. |
| | | 1m 25s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-969/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/969 |
| Optional Tests | dupname asflicense pylint |
| uname | Linux b61046349a7b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 5ff3edb |
| Max. process+thread count | 51 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-969/1/console |
| versions | git=2.7.4 maven=3.3.9 pylint=2.4.4 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #969: Phoenix 6223 could not find or load main class sqline.SqLine
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #969:
URL: https://github.com/apache/phoenix/pull/969#discussion_r525038798
##########
File path: bin/phoenix_utils.py
##########
@@ -77,7 +77,7 @@ def findClasspath(command_name):
return tryDecode(subprocess.Popen(command, shell=True, stdout=subprocess.PIPE).stdout.read())
def setPath():
- PHOENIX_CLIENT_JAR_PATTERN = "phoenix-client.jar"
+ PHOENIX_CLIENT_JAR_PATTERN = "phoenix-client*[!s][!t].jar"
Review comment:
This will still match sources:
$ls -l phoenix-client*[!s][!t].jar
-rw-r--r-- 1 stoty staff 75651719 Nov 17 11:04 phoenix-client-5.1.0-SNAPSHOT-sources.jar
-rw-r--r-- 1 stoty staff 144017266 Nov 17 11:04 phoenix-client-5.1.0-SNAPSHOT.jar
This would not:
$]ls -l phoenix-client*[!s].jar
-rw-r--r-- 1 stoty staff 144017266 Nov 17 11:04 phoenix-client-5.1.0-SNAPSHOT.jar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #969: Phoenix 6223 could not find or load main class sqline.SqLine
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #969:
URL: https://github.com/apache/phoenix/pull/969#issuecomment-734680262
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | pylint | 0m 5s | There were no new pylint issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. |
| | | 1m 26s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-969/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/969 |
| Optional Tests | dupname asflicense pylint |
| uname | Linux a61cde138491 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 457a67c |
| Max. process+thread count | 52 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-969/2/console |
| versions | git=2.7.4 maven=3.3.9 pylint=2.4.4 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #969: Phoenix 6223 could not find or load main class sqline.SqLine
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #969:
URL: https://github.com/apache/phoenix/pull/969#issuecomment-728168294
Comments from #965 are applicable here. One follow up question from the thread on #965 : Which command do you use to build phoenix-client jar?
Even with `mvn clean install -DskipTests` at project level, we should get `phoenix-client.jar` as symlink to `phoenix-client-{version}.jar` under `phoenix-client-parent/phoenix-client/target/`. Could you please try once?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org