You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2023/02/20 02:48:41 UTC
[Impala-ASF-CR] IMPALA-11932: skip test partition key scans with multiple blocks table under erasure coding
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19515
Change subject: IMPALA-11932: skip test_partition_key_scans_with_multiple_blocks_table under erasure coding
......................................................................
IMPALA-11932: skip test_partition_key_scans_with_multiple_blocks_table under erasure coding
The erasure coding policy used in our test is RS-3-2-1024k, which
requires the block size should not less than 1MB. The test introduced
in IMPALA-11081 use 'dfs.block.size=1024' to create multiple blocks
table, we should skip this test under erasure coding to avoid test
failures.
Change-Id: I0f088102c380df89f56870d901852f7dde2d72fe
---
M tests/query_test/test_queries.py
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/19515/1
--
To view, visit http://gerrit.cloudera.org:8080/19515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f088102c380df89f56870d901852f7dde2d72fe
Gerrit-Change-Number: 19515
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[Impala-ASF-CR] IMPALA-11932: skip test partition key scans with multiple blocks table under erasure coding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19515 )
Change subject: IMPALA-11932: skip test_partition_key_scans_with_multiple_blocks_table under erasure coding
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9060/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f088102c380df89f56870d901852f7dde2d72fe
Gerrit-Change-Number: 19515
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 20 Feb 2023 10:15:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11932: skip test partition key scans with multiple blocks table under erasure coding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19515 )
Change subject: IMPALA-11932: skip test_partition_key_scans_with_multiple_blocks_table under erasure coding
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12396/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f088102c380df89f56870d901852f7dde2d72fe
Gerrit-Change-Number: 19515
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 20 Feb 2023 03:08:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11932: skip test partition key scans with multiple blocks table under erasure coding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19515 )
Change subject: IMPALA-11932: skip test_partition_key_scans_with_multiple_blocks_table under erasure coding
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f088102c380df89f56870d901852f7dde2d72fe
Gerrit-Change-Number: 19515
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 20 Feb 2023 15:18:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11932: skip test partition key scans with multiple blocks table under erasure coding
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19515 )
Change subject: IMPALA-11932: skip test_partition_key_scans_with_multiple_blocks_table under erasure coding
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f088102c380df89f56870d901852f7dde2d72fe
Gerrit-Change-Number: 19515
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 20 Feb 2023 10:14:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11932: skip test partition key scans with multiple blocks table under erasure coding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19515 )
Change subject: IMPALA-11932: skip test_partition_key_scans_with_multiple_blocks_table under erasure coding
......................................................................
IMPALA-11932: skip test_partition_key_scans_with_multiple_blocks_table under erasure coding
The erasure coding policy used in our test is RS-3-2-1024k, which
requires the block size should not less than 1MB. The test introduced
in IMPALA-11081 use 'dfs.block.size=1024' to create multiple blocks
table, we should skip this test under erasure coding to avoid test
failures.
Change-Id: I0f088102c380df89f56870d901852f7dde2d72fe
Reviewed-on: http://gerrit.cloudera.org:8080/19515
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_queries.py
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Quanlong Huang: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f088102c380df89f56870d901852f7dde2d72fe
Gerrit-Change-Number: 19515
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>