You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2016/02/29 23:17:11 UTC
[GitHub] flink pull request: [FLINK-3550] [FLINK-3552] Rework WindowJoin an...
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/1745
[FLINK-3550] [FLINK-3552] Rework WindowJoin and SocketWindowWordCount example
__Note: This is based on #1744__
This pull request give some of the example a more proper streaming feeling.
## WindowJoin
This changes the example to not work on files or small static collections, but on generated infinite streams with configurable data rate. This lets users get a better feeling of continuous windowed joins.
As part of that change (remove file inputs), this also rewrites the corresponding tests.
## SocketWindowWordCount
The example describes how to open a server socket via *netcat* and connects to that socket.
It applies sliding window word counting to the created stream.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink examples
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1745.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1745
----
commit c4957ce198935a390e838ca74a610108af122ad8
Author: Stephan Ewen <se...@apache.org>
Date: 2016-02-29T18:24:34Z
[FLINK-2788] [apis] Add TypeHint class to allow type-safe generic type parsing
commit de03c00959b3001e2aadc25bd5be1f977c2a6063
Author: Stephan Ewen <se...@apache.org>
Date: 2016-02-29T21:04:26Z
[FLINK-3550] [examples] Rework WindowJoin to properly demonstrate continuous window joins (Java + Scala)
commit e903b45bdc9f2084907cd811f8230ed06046a1d9
Author: Stephan Ewen <se...@apache.org>
Date: 2016-02-29T22:00:51Z
[FLINK-3552] [examples] Add a properly windowed word count reading from a socket (Java + Scala)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3550] [FLINK-3552] Rework WindowJoin an...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1745#issuecomment-190666910
Looks good :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3550] [FLINK-3552] Rework WindowJoin an...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1745#issuecomment-195002277
Manually merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3550] [FLINK-3552] Rework WindowJoin an...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen closed the pull request at:
https://github.com/apache/flink/pull/1745
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3550] [FLINK-3552] Rework WindowJoin an...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1745#issuecomment-192363417
Will adjust the example to use the parameter tool
and merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3550] [FLINK-3552] Rework WindowJoin an...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1745#issuecomment-190667026
With two small inline comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---