You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by David McCreedy <Mc...@us.ibm.com> on 2002/05/15 20:20:10 UTC

[PATCH] TPF specific changes for syslog & flags

This patch is specific to TPF code and therefore shouldn't affect other
platforms.

It does the following:

1) Allow the use of Apache's -f, -d, -D, & -X flags on IBM's TPF
operating system
2) Allow syslog to be used by Apache on TPF
3) Remove unused expat-lite object files from the sample link JCL

Please let me know if you have any concerns or comments.

Thank you,

David McCreedy
McCreedy@us.ibm.com

Re: [PATCH] TPF specific changes for syslog & flags

Posted by Jeff Trawick <tr...@attglobal.net>.
David McCreedy <Mc...@us.ibm.com> writes:

> This patch is specific to TPF code and therefore shouldn't affect other
> platforms.
> 
> It does the following:
> 
> 1) Allow the use of Apache's -f, -d, -D, & -X flags on IBM's TPF
> operating system
> 2) Allow syslog to be used by Apache on TPF
> 3) Remove unused expat-lite object files from the sample link JCL
> 
> Please let me know if you have any concerns or comments.

no real concerns...  

a couple of comments... 

why not use malloc() instead of calloc() in the code below?

assignment statements should have spaces around the '=' (duck :) )

> +void ap_tpf_save_argv(int argc, char **argv) {
> +
> +    int i, len=3;      /* 3 for "-x "   */
> +
> +    for (i= 1; i < argc; i++) {     /* find len for calloc */
> +         len += strlen (argv[i]);
> +         ++len;                     /* 1 for blank */
> +    }
> +
> +    argv_ptr = calloc (1, len + 1);
> +    strcpy(argv_ptr, "-x");
> +    for (i= 1; i < argc; i++) {
> +         strcat(argv_ptr, " ");
> +         strcat(argv_ptr, argv[i]);
> +    }
> +}


-- 
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...