You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:18:49 UTC
[GitHub] [rocketmq-client-go] feiquan123 opened a new pull request #549: FIX:fatal error: concurrent map read and map write(apache#544)
feiquan123 opened a new pull request #549:
URL: https://github.com/apache/rocketmq-client-go/pull/549
## What is the purpose of the change
avoid `fatal error: concurrent map read and map write` when more BroadCasting clients.
## Brief changelog
use sync.Map to save `localFileOffsetStore.OffsetTable` info.
## Verifying this change
`go test . -v --run TestNewLocalFileOffsetStore` pass
`go test . -v --run TestLocalFileOffsetStore` pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-io commented on pull request #549: FIX:fatal error: concurrent map read and map write(apache#544)
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #549:
URL: https://github.com/apache/rocketmq-client-go/pull/549#issuecomment-720358152
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/549?src=pr&el=h1) Report
> Merging [#549](https://codecov.io/gh/apache/rocketmq-client-go/pull/549?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/2a6556176df6c4c7b3bc6cc1c7267660e39c6a0f?el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/549?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #549 +/- ##
==========================================
+ Coverage 24.22% 24.31% +0.09%
==========================================
Files 48 48
Lines 5008 5017 +9
==========================================
+ Hits 1213 1220 +7
- Misses 3597 3598 +1
- Partials 198 199 +1
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/549?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [consumer/offset\_store.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/549/diff?src=pr&el=tree#diff-Y29uc3VtZXIvb2Zmc2V0X3N0b3JlLmdv) | `65.09% <100.00%> (+1.19%)` | :arrow_up: |
| [internal/namesrv.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/549/diff?src=pr&el=tree#diff-aW50ZXJuYWwvbmFtZXNydi5nbw==) | `60.52% <0.00%> (-3.37%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/549?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/549?src=pr&el=footer). Last update [2a65561...e00c253](https://codecov.io/gh/apache/rocketmq-client-go/pull/549?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] feiquan123 closed pull request #549: FIX:fatal error: concurrent map read and map write(apache#544)
Posted by GitBox <gi...@apache.org>.
feiquan123 closed pull request #549:
URL: https://github.com/apache/rocketmq-client-go/pull/549
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-io edited a comment on pull request #549: FIX:fatal error: concurrent map read and map write(apache#544)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #549:
URL: https://github.com/apache/rocketmq-client-go/pull/549#issuecomment-720358152
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/549?src=pr&el=h1) Report
> Merging [#549](https://codecov.io/gh/apache/rocketmq-client-go/pull/549?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/2a6556176df6c4c7b3bc6cc1c7267660e39c6a0f?el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/549?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #549 +/- ##
==========================================
+ Coverage 24.22% 24.31% +0.09%
==========================================
Files 48 48
Lines 5008 5017 +9
==========================================
+ Hits 1213 1220 +7
- Misses 3597 3598 +1
- Partials 198 199 +1
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/549?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [consumer/offset\_store.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/549/diff?src=pr&el=tree#diff-Y29uc3VtZXIvb2Zmc2V0X3N0b3JlLmdv) | `65.09% <100.00%> (+1.19%)` | :arrow_up: |
| [internal/namesrv.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/549/diff?src=pr&el=tree#diff-aW50ZXJuYWwvbmFtZXNydi5nbw==) | `60.52% <0.00%> (-3.37%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/549?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/549?src=pr&el=footer). Last update [2a65561...e00c253](https://codecov.io/gh/apache/rocketmq-client-go/pull/549?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org