You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2017/12/27 06:45:04 UTC

[GitHub] sijie commented on a change in pull request #1009: Add optional key/value metadata to producers.

sijie commented on a change in pull request #1009: Add optional key/value metadata to producers.
URL: https://github.com/apache/incubator-pulsar/pull/1009#discussion_r158769125
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -230,6 +230,9 @@ message CommandProducer {
 	/// If a producer name is specified, the name will be used,
 	/// otherwise the broker will generate a unique name
 	optional string producer_name = 4;
+
+	/// Add optional metadata key=value to this producer
+	repeated KeyValue metadata    = 5;
 
 Review comment:
   `repeated` is an optional field in protobuf. it means this field can be repeated any number of times (including zero). I don't think you can use `optional` `repeated` together. in proto2 syntax, a field has to be one of 'required', 'optional' and 'repeated'.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services