You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/02 02:55:37 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request, #22580: Revise 22557
sandynz opened a new pull request, #22580:
URL: https://github.com/apache/shardingsphere/pull/22580
Related to #22557.
Changes proposed in this pull request:
- Fix ShardingSphereDriverURL.toConfigurationBytes ignore newline
- Improve ShardingSphereDriverTest. Do real test, make sure driver works
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #22580: Revise 22557
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #22580:
URL: https://github.com/apache/shardingsphere/pull/22580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revise 22557 [shardingsphere]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #22580:
URL: https://github.com/apache/shardingsphere/pull/22580#issuecomment-4175386679
## [Codecov](https://app.codecov.io/gh/apache/shardingsphere/pull/22580?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 50.59%. Comparing base ([`e4cb223`](https://app.codecov.io/gh/apache/shardingsphere/commit/e4cb223a7df5324e27ca3a875c4d7cb9fffc94a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`aebd90a`](https://app.codecov.io/gh/apache/shardingsphere/commit/aebd90ad12e09a8d1e33c65e8465182b35aee6bd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11970 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #22580 +/- ##
============================================
- Coverage 50.63% 50.59% -0.04%
+ Complexity 2470 2460 -10
============================================
Files 4115 4115
Lines 57586 57607 +21
Branches 9827 9834 +7
============================================
- Hits 29156 29148 -8
- Misses 25930 25952 +22
- Partials 2500 2507 +7
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/shardingsphere/pull/22580?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org