Re: cvs commit: jakarta-taglibs/standard/src/org/apache/taglibs/standard/tag/common/sql UpdateTagSupport.java TransactionTagSupport.java QueryTagSupport.java ParamTagSupport.java DriverTagSupport.java DataSourceWrapper.java

[Ted Husted <hu...@apache.org>]

Please take this in the spirit it is given. 

http://jakarta.apache.org/site/source.html

"All Java Language source code in the repository must be written in
conformance to
the "Code Conventions for the Java Programming Language as published by
Sun."

Accordingly, omitting the braches in an if statement

>         if (var != null)
>             pageContext.setAttribute(var, new Integer(result), scope);

should be avoided 

http://java.sun.com/docs/codeconv/html/CodeConventions.doc6.html#431

in favor of 

>       if (var != null) {
>       	pageContext.setAttribute(var, new Integer(result), scope);
	}

Just so you know.

-- Ted Husted.

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>