[jira] [Commented] (GIRAPH-325) A few more progress calls

["Eli Reisman (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455402#comment-13455402 ] 

Eli Reisman commented on GIRAPH-325:
------------------------------------

Interesting idea here for sure, but I don't think you can replace the write() signature in a Writable without breaking Giraph's interaction with that class of Writables.

But...adding more progress() calls where loops of these Writables are written/read is a good idea if you know each one is large and will take a while. I do think unless each instance you are protecting takes longer than 30 seconds to load you're very safe calling progress() in between serializations of single objects rather than during the serialization calls.

There are also other places where Giraph does not call progress() often enough to please Hadoop, see GIRAPH-274.

                
> A few more progress calls
> -------------------------
>
>                 Key: GIRAPH-325
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-325
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Priority: Minor
>         Attachments: GIRAPH-325.patch
>
>
> (Posting issue and the patch from a colleague)
> Call progress on a few more places.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira