[GitHub] ashb commented on a change in pull request #4201: [AIRFLOW-3360] Make the DAGs search respect other querystring parameters

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #4201: [AIRFLOW-3360] Make the DAGs search respect other querystring parameters
URL: https://github.com/apache/incubator-airflow/pull/4201#discussion_r238074516
 
 

 ##########
 File path: airflow/www_rbac/templates/airflow/dags.html
 ##########
 @@ -235,11 +235,32 @@ <h2>DAGs</h2>
       const DAGS_INDEX = "{{ url_for('Airflow.index') }}";
       const ENTER_KEY_CODE = 13;
 
+      function createOrAppendToQueryString(parameter, value) {
+        var query_string_parameters = {};
+        if (typeof window.location.search !== "undefined") {
+          window.location.search.substr(1).split('&').forEach(function (query_string_parameter) {
 
 Review comment:
   In this case it is okay - the non "rbac" version will be deleted from the tree soon-ish.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services