You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Nick Howes (JIRA)" <ji...@apache.org> on 2011/04/14 14:59:05 UTC

[jira] [Created] (SSHD-116) Shouldn't throw an exception when receiving an unsupported SFTP message

Shouldn't throw an exception when receiving an unsupported SFTP message
-----------------------------------------------------------------------

                 Key: SSHD-116
                 URL: https://issues.apache.org/jira/browse/SSHD-116
             Project: MINA SSHD
          Issue Type: Bug
            Reporter: Nick Howes


Unsupported SFTP message types should just respond with SSH_FX_OP_UNSUPPORTED, and not also throw an exception, since that ends the session. When I use Ubuntu's Nautilus integration for SFTP that attempts READLINK requests quite a lot, which are currently unimplemented in SftpSubsytem. If we stop throwing the exception and just return the unsupported response, it works fine.

Attaching a patch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SSHD-116) Shouldn't throw an exception when receiving an unsupported SFTP message

Posted by "Nick Howes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SSHD-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick Howes updated SSHD-116:
----------------------------

    Attachment: sftp-unsupported-op.patch

Patch attached.

> Shouldn't throw an exception when receiving an unsupported SFTP message
> -----------------------------------------------------------------------
>
>                 Key: SSHD-116
>                 URL: https://issues.apache.org/jira/browse/SSHD-116
>             Project: MINA SSHD
>          Issue Type: Bug
>            Reporter: Nick Howes
>              Labels: sftp
>         Attachments: sftp-unsupported-op.patch
>
>
> Unsupported SFTP message types should just respond with SSH_FX_OP_UNSUPPORTED, and not also throw an exception, since that ends the session. When I use Ubuntu's Nautilus integration for SFTP that attempts READLINK requests quite a lot, which are currently unimplemented in SftpSubsytem. If we stop throwing the exception and just return the unsupported response, it works fine.
> Attaching a patch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SSHD-116) Shouldn't throw an exception when receiving an unsupported SFTP message

Posted by "Nick Howes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SSHD-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick Howes updated SSHD-116:
----------------------------

    Attachment: sftp-unsupported-op.patch

> Shouldn't throw an exception when receiving an unsupported SFTP message
> -----------------------------------------------------------------------
>
>                 Key: SSHD-116
>                 URL: https://issues.apache.org/jira/browse/SSHD-116
>             Project: MINA SSHD
>          Issue Type: Bug
>            Reporter: Nick Howes
>              Labels: sftp
>         Attachments: sftp-unsupported-op.patch
>
>
> Unsupported SFTP message types should just respond with SSH_FX_OP_UNSUPPORTED, and not also throw an exception, since that ends the session. When I use Ubuntu's Nautilus integration for SFTP that attempts READLINK requests quite a lot, which are currently unimplemented in SftpSubsytem. If we stop throwing the exception and just return the unsupported response, it works fine.
> Attaching a patch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SSHD-116) Shouldn't throw an exception when receiving an unsupported SFTP message

Posted by "Nick Howes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SSHD-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick Howes updated SSHD-116:
----------------------------

    Attachment:     (was: sftp-unsupported-op.patch)

> Shouldn't throw an exception when receiving an unsupported SFTP message
> -----------------------------------------------------------------------
>
>                 Key: SSHD-116
>                 URL: https://issues.apache.org/jira/browse/SSHD-116
>             Project: MINA SSHD
>          Issue Type: Bug
>            Reporter: Nick Howes
>              Labels: sftp
>         Attachments: sftp-unsupported-op.patch
>
>
> Unsupported SFTP message types should just respond with SSH_FX_OP_UNSUPPORTED, and not also throw an exception, since that ends the session. When I use Ubuntu's Nautilus integration for SFTP that attempts READLINK requests quite a lot, which are currently unimplemented in SftpSubsytem. If we stop throwing the exception and just return the unsupported response, it works fine.
> Attaching a patch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (SSHD-116) Shouldn't throw an exception when receiving an unsupported SFTP message

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SSHD-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved SSHD-116.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.6.0
         Assignee: Guillaume Nodet

> Shouldn't throw an exception when receiving an unsupported SFTP message
> -----------------------------------------------------------------------
>
>                 Key: SSHD-116
>                 URL: https://issues.apache.org/jira/browse/SSHD-116
>             Project: MINA SSHD
>          Issue Type: Bug
>            Reporter: Nick Howes
>            Assignee: Guillaume Nodet
>              Labels: sftp
>             Fix For: 0.6.0
>
>         Attachments: sftp-unsupported-op.patch
>
>
> Unsupported SFTP message types should just respond with SSH_FX_OP_UNSUPPORTED, and not also throw an exception, since that ends the session. When I use Ubuntu's Nautilus integration for SFTP that attempts READLINK requests quite a lot, which are currently unimplemented in SftpSubsytem. If we stop throwing the exception and just return the unsupported response, it works fine.
> Attaching a patch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira