You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/04 22:46:11 UTC

[GitHub] [tvm] csullivan commented on pull request #7711: [Texture support][Part 0] Device API and runtime support

csullivan commented on pull request #7711:
URL: https://github.com/apache/tvm/pull/7711#issuecomment-832296233


   @tqchen, @ZihengJiang, would you kindly consider reviewing once more? 
   
   The main change is to remove texture specific device apis and rely on `tir.tvm_call_packed` (cf #7932) for texture workspace allocations and AllocDataSpace (w/ scope). 
   
   I also introduced an opencl buffer descriptor that tracks the allocation layout. With the layout and the DLTensor CopyDataFromTo overload I've verified that a sub-texture allocation can be correctly copied out of a 2d texture pool of larger extent. This solves an issue I raised in [Part 4](https://github.com/apache/tvm/pull/7689/files#diff-409f906bd8fdca700e76726e204f722ae4b8a8ab39376ffb9bb46434d063678cR63-R71).
   
   I appreciate any additional feedback you have.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org