You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by rf...@apache.org on 2014/01/02 22:15:37 UTC

svn commit: r1554921 - in /maven/plugins/trunk/maven-compiler-plugin/src: it/MCOMPILER-129/ it/MCOMPILER-129/src/ it/MCOMPILER-129/src/main/ it/MCOMPILER-129/src/main/java/ main/java/org/apache/maven/plugin/compiler/

Author: rfscholte
Date: Thu Jan  2 21:15:36 2014
New Revision: 1554921

URL: http://svn.apache.org/r1554921
Log:
[MCOMPILER-129] unable to pass in javac -J option
Add IT, issue already fixed in 2.4

Added:
    maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/
    maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/invoker.properties
    maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/pom.xml
    maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/src/
    maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/src/main/
    maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/src/main/java/
    maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/src/main/java/MyClass.java
Modified:
    maven/plugins/trunk/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java

Added: maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/invoker.properties
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/invoker.properties?rev=1554921&view=auto
==============================================================================
--- maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/invoker.properties (added)
+++ maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/invoker.properties Thu Jan  2 21:15:36 2014
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+invoker.goals = clean compile
\ No newline at end of file

Added: maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/pom.xml
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/pom.xml?rev=1554921&view=auto
==============================================================================
--- maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/pom.xml (added)
+++ maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/pom.xml Thu Jan  2 21:15:36 2014
@@ -0,0 +1,55 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <groupId>org.apache.maven.plugins.compiler.it</groupId>
+  <artifactId>mcompiler-129</artifactId>
+  <version>1.0-SNAPSHOT</version>
+
+  <description>
+    Test to verify usage of javac -J option
+  </description>
+
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>@project.version@</version>
+        <configuration>
+          <fork>true</fork>
+          <source>1.5</source>
+          <target>1.5</target>
+          <!-- this has been deprecated, but still works  
+            <compilerArguments>
+              <J-Duser.language>en_us</J-Duser.language>
+            </compilerArguments>
+           -->
+          <compilerArgs>
+            <compilerArg>-J-Duser.language=en_us</compilerArg>
+          </compilerArgs>
+        </configuration>
+      </plugin>
+    </plugins>
+  </build>
+</project>

Added: maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/src/main/java/MyClass.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/src/main/java/MyClass.java?rev=1554921&view=auto
==============================================================================
--- maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/src/main/java/MyClass.java (added)
+++ maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-129/src/main/java/MyClass.java Thu Jan  2 21:15:36 2014
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+public class MyClass
+{
+
+}

Modified: maven/plugins/trunk/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java?rev=1554921&r1=1554920&r2=1554921&view=diff
==============================================================================
--- maven/plugins/trunk/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java (original)
+++ maven/plugins/trunk/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java Thu Jan  2 21:15:36 2014
@@ -247,6 +247,7 @@ public abstract class AbstractCompilerMo
      * &lt;compilerArgs&gt;
      *   &lt;arg&gt;-Xmaxerrs=1000&lt;/arg&gt;
      *   &lt;arg&gt;-Xlint&lt;/arg&gt;
+     *   &lt;arg&gt;-J-Duser.language=en_us&lt;/arg&gt;
      * &lt;/compilerArgs&gt;
      * </pre>
      *