You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jane Chan (Jira)" <ji...@apache.org> on 2024/01/11 09:32:00 UTC

[jira] [Updated] (FLINK-34060) Migrate UserDefinedTableAggFunctions to JavaUserDefinedTableAggFunctions

     [ https://issues.apache.org/jira/browse/FLINK-34060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jane Chan updated FLINK-34060:
------------------------------
    Description: 
The issue is discovered when testing FLINK-31788.

The Top3 function emits a tuple of (entry.getKey, entry.getKey) see [UserDefinedTableAggFunctions.scala#L127|https://github.com/apache/flink/blob/907d0f32126b9f8acfc80f3f4098e71cb37f0e37/flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/UserDefinedTableAggFunctions.scala#L127], which is peculiar.

Meanwhile, consider getting the scala-free goal; it's time to migrate this class to the `JavaUserDefinedTableAggFunctions`, and revisit the implementation.

  was:
The issue is discovered when testing FLINK-31788.


The Top3 function emits a tuple of (entry.getKey, entry.getKey) [UserDefinedTableAggFunctions.scala#L127|https://github.com/apache/flink/blob/907d0f32126b9f8acfc80f3f4098e71cb37f0e37/flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/UserDefinedTableAggFunctions.scala#L127], which is peculiar.

Meanwhile, consider getting the scala-free goal; it's time to migrate this class to the `JavaUserDefinedTableAggFunctions`, and revisit the implementation.


> Migrate UserDefinedTableAggFunctions to JavaUserDefinedTableAggFunctions
> ------------------------------------------------------------------------
>
>                 Key: FLINK-34060
>                 URL: https://issues.apache.org/jira/browse/FLINK-34060
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Table SQL / Runtime
>    Affects Versions: 1.19.0
>            Reporter: Jane Chan
>            Assignee: Jane Chan
>            Priority: Major
>
> The issue is discovered when testing FLINK-31788.
> The Top3 function emits a tuple of (entry.getKey, entry.getKey) see [UserDefinedTableAggFunctions.scala#L127|https://github.com/apache/flink/blob/907d0f32126b9f8acfc80f3f4098e71cb37f0e37/flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/UserDefinedTableAggFunctions.scala#L127], which is peculiar.
> Meanwhile, consider getting the scala-free goal; it's time to migrate this class to the `JavaUserDefinedTableAggFunctions`, and revisit the implementation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)