[GitHub] akshayrai commented on a change in pull request #3832: [TE] Extend anomalies endpoint to fetch by metric/dataset and true an…

[GitBox <gi...@apache.org>]

akshayrai commented on a change in pull request #3832: [TE] Extend anomalies endpoint to fetch by metric/dataset and true an…
URL: https://github.com/apache/incubator-pinot/pull/3832#discussion_r256639996
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/api/user/dashboard/UserDashboardResource.java
 ##########
 @@ -345,7 +370,17 @@ public int compare(MergedAnomalyResultDTO o1, MergedAnomalyResultDTO o2) {
     return output;
   }
 
+  private Collection<? extends MergedAnomalyResultDTO> fetchFrameworkAnomaliesByMetricDataset(
+      List<Predicate> predicates) {
+    predicates.add(Predicate.NEQ("detectionConfigId", 0));
 
 Review comment:
   Anomalies is a list. This is a safety condition that avoids potential duplicates.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org