You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2024/02/20 10:51:07 UTC
[PR] Ignore smart-builder core extension, if present. [maven-mvnd]
cstamas opened a new pull request, #916:
URL: https://github.com/apache/maven-mvnd/pull/916
Fixes #912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ignore smart-builder core extension, if present. [maven-mvnd]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #916:
URL: https://github.com/apache/maven-mvnd/pull/916#issuecomment-2026936793
Do not merge pls, I want to extend this pr: with user configurable GA list to ignore (where smart builder is present "by default").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ignore smart-builder core extension, if present. [maven-mvnd]
Posted by "wendigo (via GitHub)" <gi...@apache.org>.
wendigo commented on PR #916:
URL: https://github.com/apache/maven-mvnd/pull/916#issuecomment-2067641748
Just tested the master build with Trino and it seems to ignore the default property value for `MVND_CORE_EXTENSIONS_EXCLUDE` while the explicitly passed `-Dmvnd.coreExtensionsExclude` works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ignore smart-builder core extension, if present. [maven-mvnd]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #916:
URL: https://github.com/apache/maven-mvnd/pull/916#issuecomment-2027506539
@ppalaga @gnodet @wendigo pls review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ignore smart-builder core extension, if present. [maven-mvnd]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #916:
URL: https://github.com/apache/maven-mvnd/pull/916#issuecomment-2067640854
```
[INFO] ------------------------------------------------------------------------
[ERROR] class io.takari.maven.builder.smart.DependencyGraph cannot be cast to class io.takari.maven.builder.smart.DependencyGraph (io.takari.maven.builder.smart.DependencyGraph is in unnamed module of loader org.codehaus.plexus.classworlds.realm.ClassRealm @17a7cec2; io.takari.maven.builder.smart.DependencyGraph is in unnamed module of loader org.codehaus.plexus.classworlds.realm.ClassRealm @6a9b0a6f)java.lang.ClassCastException: class io.takari.maven.builder.smart.DependencyGraph cannot be cast to class io.takari.maven.builder.smart.DependencyGraph (io.takari.maven.builder.smart.DependencyGraph is in unnamed module of loader org.codehaus.plexus.classworlds.realm.ClassRealm @17a7cec2; io.takari.maven.builder.smart.DependencyGraph is in unnamed module of loader org.codehaus.plexus.classworlds.realm.ClassRealm @6a9b0a6f)
at io.takari.maven.builder.smart.DependencyGraph.fromMaven (DependencyGraph.java:40)
at io.takari.maven.builder.smart.SmartBuilder.build (SmartBuilder.java:88)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
at org.apache.maven.cli.DaemonMavenCli.execute (DaemonMavenCli.java:858)
at org.apache.maven.cli.DaemonMavenCli.doMain (DaemonMavenCli.java:253)
at org.apache.maven.cli.DaemonMavenCli.main (DaemonMavenCli.java:230)
at org.mvndaemon.mvnd.daemon.Server.handle (Server.java:612)
at org.mvndaemon.mvnd.daemon.Server.client (Server.java:288)
at org.mvndaemon.mvnd.daemon.Server.lambda$accept$2 (Server.java:250)
at java.lang.Thread.run (Thread.java:1570)
[ERROR]
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
```
Also,
```
mvnd clean install -e -Dmvnd.coreExtensionsExclude=io.takari.maven:takari-smart-builder
```
works but seems kinda default value is ignored?
@gnodet @ppalaga
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ignore smart-builder core extension, if present. [maven-mvnd]
Posted by "wendigo (via GitHub)" <gi...@apache.org>.
wendigo commented on PR #916:
URL: https://github.com/apache/maven-mvnd/pull/916#issuecomment-1955950620
@gnodet can we get this merged and expect new release soon :)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ignore smart-builder core extension, if present. [maven-mvnd]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #916:
URL: https://github.com/apache/maven-mvnd/pull/916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ignore smart-builder core extension, if present. [maven-mvnd]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #916:
URL: https://github.com/apache/maven-mvnd/pull/916#issuecomment-2053687725
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ignore smart-builder core extension, if present. [maven-mvnd]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #916:
URL: https://github.com/apache/maven-mvnd/pull/916#issuecomment-2067646317
Def value handling here https://github.com/apache/maven-mvnd/pull/953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org