[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4727: Marvin3

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #4727:
URL: https://github.com/apache/cloudstack/pull/4727#discussion_r588144331



##########
File path: packaging/centos7/cloud.spec
##########
@@ -418,6 +424,8 @@ fi
 # Install mysql-connector-python
 pip3 install %{_datadir}/%{name}-management/setup/wheel/six-1.15.0-py2.py3-none-any.whl %{_datadir}/%{name}-management/setup/wheel/setuptools-47.3.1-py3-none-any.whl %{_datadir}/%{name}-management/setup/wheel/protobuf-3.12.2-cp36-cp36m-manylinux1_x86_64.whl %{_datadir}/%{name}-management/setup/wheel/mysql_connector_python-8.0.20-cp36-cp36m-manylinux1_x86_64.whl
 
+pip3 install urllib3

Review comment:
       I'll double check, I think it's an indirect dependency, Also it is not packaged which is mayby not what we want , I would mean internet has to be available during install. I'll look into this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org