[GitHub] [incubator-openwhisk-cli] mdeuser commented on a change in pull request #438: Update tests to react to provide-api-key toggle

[GitBox <gi...@apache.org>]

mdeuser commented on a change in pull request #438: Update tests to react to provide-api-key toggle
URL: https://github.com/apache/incubator-openwhisk-cli/pull/438#discussion_r281637167
 
 

 ##########
 File path: tests/src/test/scala/org/apache/openwhisk/core/cli/test/WskCliBasicUsageTests.scala
 ##########
 @@ -653,37 +653,43 @@ class WskCliBasicUsageTests extends TestHelpers with WskTestHelpers {
     val createAnnots = Map(createKey -> createValue, origKey -> origValue)
     val updateAnnots =
       Map(updateKey -> updateValue, origKey -> overwrittenValue)
+    val baseAnnotations =
+      Parameters("web-export", JsTrue) ++
+        Parameters("raw-http", JsFalse) ++
+        Parameters("final", JsTrue) ++
+        Parameters("exec", "nodejs:6")
+    val createAnnotations = if (requireAPIKeyAnnotation) {
+      baseAnnotations ++
+        Parameters(WhiskAction.provideApiKeyAnnotationName, JsFalse) ++
+        Parameters(createKey, createValue) ++
+        Parameters(origKey, origValue)
+    } else {
+      baseAnnotations ++
+        Parameters(createKey, createValue) ++
 
 Review comment:
   @dubee - should the `createKey` and `origKey` be included in the base annotation list?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services