[jira] [Commented] (DISPATCH-1374) Add qdstat options --all-routers and all-entities which display statistics of all routers and displays all entities

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DISPATCH-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885466#comment-16885466 ] 

ASF GitHub Bot commented on DISPATCH-1374:
------------------------------------------

ChugR commented on pull request #527: DISPATCH-1374 - Added qdstat options --all-routers and --all-entities
URL: https://github.com/apache/qpid-dispatch/pull/527#discussion_r303567508
 
 

 ##########
 File path: tools/qdstat.in
 ##########
 @@ -57,23 +58,31 @@ def parse_args(argv):
     parser.add_option("-m", "--memory", help="Show Router Memory Stats",    action="store_const", const="m",   dest="show")
     parser.add_option("--autolinks", help="Show Auto Links",                action="store_const", const="autolinks",  dest="show")
     parser.add_option("--linkroutes", help="Show Link Routes",              action="store_const", const="linkroutes", dest="show")
+
+    parser.add_option("--all-routers", help="Show entities for all routers in network. Can also be used in combination with other options",  action="store_const", const="all_routers",  dest="all_routers")
+    parser.add_option("--all-entities", help="Show all router entities. Can be combined with --all-routers option", action="store_const", const="all_entities", dest="all_entities")
+
     parser.add_option("-v", "--verbose", help="Show maximum detail",        action="store_true", dest="verbose")
     parser.add_option("--log", help="Show recent log entries", action="store_const", const="log", dest="show")
 
     # This limit can be used to limit the number of output rows and
     # can be used in conjunction with options
     # like -c, -l, -a, --autolinks, --linkroutes and --log.
     # By default, the limit is not set, which means the limit is unlimited.
-
     parser.add_option("--limit", help="Limit number of output rows", type="int", default=None)
 
     opts, args = parser.parse_args(args=argv)
 
-    if not opts.show:
-        parser.error("You must specify one of these options: -g, -c, -l, -n, -a, -m, -h, --autolinks, --linkroutes, or --log.")
+    if opts.router and opts.all_routers:
+        parser.error("--all-routers cannot be combined with single router option -r " + opts.router)
 
-    return opts, args
+    if opts.all_entities and opts.show:
+           parser.error("--all-entities cannot be combined with specific entity option -" + opts.show)
+
+    if not opts.all_routers and not opts.all_entities and not opts.show:
+        parser.error("You must specify one of these options: -g, -c, -l, -n, -a, -m, -h, --autolinks, --linkroutes, --all-routers, --all-entities or --log.")
 
 Review comment:
   The new --all-entities switch would make a great default in the event of no other option. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add qdstat options --all-routers and all-entities which display statistics of all routers and displays all entities
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: DISPATCH-1374
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1374
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Container
>    Affects Versions: 1.7.0
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Major
>             Fix For: 1.9.0
>
>
> # Introduce two new command line options to qdstat called --all-routers and --all-entities
>  # qdstat --all-routers - Is the same as - qdstat --all-routers --all-entities.
>  ## Will display information on all entities from all interior routers if the qdstat client connects to an interior router.
>  ## Will display information on all entities from only that edge router if the qdstat client connects to an edge router
>  # qdstat --all-entities
>  ## Will display information on all entities from only that interior or edge router that the qdstat client is connecting to.
>  # qdstat --all-entities -c  
>  ## Error. Cannot ask for all entities and also specifically ask for connection entity ?
>  # qdstat -c
>  ## As usual, just display connections in the router that the qdstat client is connecting to
>  # qdstat -c --all-routers
>  ## Will display connection information for all interior routers in the network if the qdstat client is connected to an interior router
>  ## Will display connection information for only that edge router if the qdstat client is connected to and edge router.
>  # qdstat --all-entities --all-routers
>  ## Same as qdstat --all-routers (see #2)
>  # General stuff
>  # Include date timestamp when the dump was taken
>  # Display in stdout just like other qdstat options
>  # Aggregated output must consist of distinct sections which pertain to each router and should be preceded by the router id for easy identification



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org