[GitHub] [lucene-solr] iverase commented on a change in pull request #762: LUCENE-8903: Add LatLonShape point query

[GitBox <gi...@apache.org>]

iverase commented on a change in pull request #762: LUCENE-8903: Add LatLonShape point query
URL: https://github.com/apache/lucene-solr/pull/762#discussion_r300545424
 
 

 ##########
 File path: lucene/sandbox/src/test/org/apache/lucene/document/BaseLatLonShapeTestCase.java
 ##########
 @@ -457,7 +464,103 @@ public void collect(int doc) throws IOException {
             b.append("  shape=" + shapes[id] + "\n");
           }
           b.append("  deleted?=" + (liveDocs != null && liveDocs.get(docID) == false));
-          b.append("  rect=Rectangle(lat=" + quantizeLatCeil(rect.minLat) + " TO " + quantizeLat(rect.maxLat) + " lon=" + qMinLon + " TO " + quantizeLon(rect.maxLon) + ")\n");          if (true) {
+          b.append("  rect=Rectangle(lat=" + quantizeLatCeil(rect.minLat) + " TO " + quantizeLat(rect.maxLat) + " lon=" + qMinLon + " TO " + quantizeLon(rect.maxLon) + ")\n");
+          if (true) {
+            fail("wrong hit (first of possibly more):\n\n" + b);
+          } else {
+            System.out.println(b.toString());
+            fail = true;
+          }
 
 Review comment:
   It seems all this verify functions contain this piece of logic. I guess they were introduced for debugging so I don't want to change it in this PR. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org