You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/03 11:19:19 UTC
[GitHub] [druid] clintropolis opened a new pull request #11873: allow dictionary encoded columns with non-string dictionaries to use bitmap index
clintropolis opened a new pull request #11873:
URL: https://github.com/apache/druid/pull/11873
### Description
Follow-up to #11829, this modifies ` interface BitmapIndexConverter<T>
{
@Nullable
T fromString(@Nullable String value);
@Nullable
String toString(@Nullable T value);
}` to be generic to support use with dictionary encoded columns which do not contain string dictionaries. A much more invasive but potentially better refactor would be to modify `BitmapIndex` itself to no longer rely on strings, but I will save that change for another day.
Conversion between string values from `BitmapIndex` callers and the underlying dictionary (which is now relaxed to just require `Indexed` instead of `GenericIndexed`) is provided by a new interface
```
interface BitmapIndexConverter<T>
{
@Nullable
T fromString(@Nullable String value);
@Nullable
String toString(@Nullable T value);
}
```
which is given to the constructor of `BitmapIndexColumnPartSupplier`, and a default pass-through string implementation has been added.
I've also modified `DimensionHandler` to allow defining a `DimensionSpec` appropriate for the type of dimension being handled, which is now used `DictionaryEncodedColumnIndexer.makeColumnValueSelector`, so that more type appropriate column selectors can be created.
<hr>
##### Key changed/added classes in this PR
* `BitmapIndexColumnPartSupplier`
* `DimensionHandler`
* `DictionaryEncodedColumnPartSupplier`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #11873: use correct DimensionSpec with for column value selectors created from dictionary encoded column indexers
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11873:
URL: https://github.com/apache/druid/pull/11873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #11873: use correct DimensionSpec with for column value selectors created from dictionary encoded column indexers
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11873:
URL: https://github.com/apache/druid/pull/11873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #11873: use correct DimensionSpec with for column value selectors created from dictionary encoded column indexers
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11873:
URL: https://github.com/apache/druid/pull/11873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org