[GitHub] [nifi] bbende commented on a change in pull request #3295: NIFI-5956 Option BlockCache for HBase Scan Processor

[GitBox <gi...@apache.org>]

bbende commented on a change in pull request #3295: NIFI-5956 Option BlockCache for HBase Scan Processor
URL: https://github.com/apache/nifi/pull/3295#discussion_r265168786
 
 

 ##########
 File path: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java
 ##########
 @@ -209,6 +209,17 @@
             .addValidator(StandardValidators.CHARACTER_SET_VALIDATOR)
             .build();
 
+    static final PropertyDescriptor BLOCK_CACHE = new PropertyDescriptor.Builder()
+            .displayName("Block Cache")
+            .name("block-cache")
+            .description("The Block Cache to enable/disable block cache on HBase scan.")
+            .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+            .allowableValues("true", "false")
+            .required(false)
+            .defaultValue("false")
 
 Review comment:
   Since the HBase Scan object has `boolean cacheBlocks = true;` by default, do you think we should make this default to true?
   
   If we default to false then anyone using this processor will stop using block cache without realizing it.
   
   Also, since we are providing a default value then we can make this required. If its not required then the UI shows an option of No Value in the values list, but if you choose that and click apply, it just puts back the default. If you make it required then there is no option of No Value, just true or false.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services