You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "anchao (via GitHub)" <gi...@apache.org> on 2023/02/28 06:57:21 UTC
[GitHub] [nuttx-apps] anchao opened a new pull request, #1603: Application: fix multiple main target mismatch during incremental compile
anchao opened a new pull request, #1603:
URL: https://github.com/apache/nuttx-apps/pull/1603
## Summary
Application: fix multiple main target mismatch during incremental compile
MAINSRC will fail to match with PROGNAME if one of main source is changed in incremental compilation
this PR will correct this issue.
Signed-off-by: chao an <an...@xiaomi.com>
## Impact
N/A
## Testing
ci check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1603: Application: fix multiple main target mismatch during incremental compile
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1603:
URL: https://github.com/apache/nuttx-apps/pull/1603#discussion_r1123561483
##########
Application.mk:
##########
@@ -202,17 +202,31 @@ else
MAINNAME := $(addsuffix _main,$(PROGNAME))
+define getentryindex
Review Comment:
```suggestion
define GETENTRYINDEX
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] jerpelea merged pull request #1603: Application: fix multiple main target mismatch during incremental compile
Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea merged PR #1603:
URL: https://github.com/apache/nuttx-apps/pull/1603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] anchao commented on a diff in pull request #1603: Application: fix multiple main target mismatch during incremental compile
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #1603:
URL: https://github.com/apache/nuttx-apps/pull/1603#discussion_r1129014263
##########
Application.mk:
##########
@@ -202,17 +202,31 @@ else
MAINNAME := $(addsuffix _main,$(PROGNAME))
+define getentryindex
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org