[GitHub] [incubator-pinot] npawar opened a new pull request #5355: Remove some timeFieldSpec constructors

[GitBox <gi...@apache.org>]

npawar opened a new pull request #5355:
URL: https://github.com/apache/incubator-pinot/pull/5355


   As part of https://github.com/apache/incubator-pinot/issues/2756 we are going to move away from TimeFieldSpec and instead use DateTimeFieldSpec.
   
   We have a lot of constructors for TimeFieldSpec. Most of those constructor calls will be replaced by equivalent DateTimeFieldSpec constructor calls. After the final change to DateTimeFieldSpec, other than tests, no one should be calling these constructors. We will keep some basic constructor around, for the backward compatibility tests.
   
   In this PR, 
   1) attempting to clean up 9 constructors, keeping only 4 basic ones. 
   2) Wherever possible, using SchemaBuilder in tests.
   This will make it one more step easier to switch over to the new stuff.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org