[GitHub] [solr] risdenk commented on a diff in pull request #1003: SOLR-16408: TestHdfsUpdateLog, TestRecoveryHdfs, and TestRandomCollapseQParserPlugin try to deleteCore twice

[GitBox <gi...@apache.org>]

risdenk commented on code in PR #1003:
URL: https://github.com/apache/solr/pull/1003#discussion_r972266388


##########
solr/modules/hdfs/src/test/org/apache/solr/hdfs/search/TestRecoveryHdfs.java:
##########
@@ -109,17 +109,13 @@ public static void afterClass() throws Exception {
     IOUtils.closeQuietly(fs);
     fs = null;
     try {
-      deleteCore();

Review Comment:
   I wonder if it actually makes more sense to call the super afterclass method here instead - since that would clean stuff up in reverse order potentially. At least in the case of HDFS it makes sense to shutdown HDFS after shutting down solr I think...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org