[jira] [Commented] (MCHECKSTYLE-421) Audit events should use Maven logging

["Michael Osipov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MCHECKSTYLE-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654484#comment-17654484 ] 

Michael Osipov commented on MCHECKSTYLE-421:
--------------------------------------------

Question is whether checkstlye itself needs a fix first...

> Audit events should use Maven logging
> -------------------------------------
>
>                 Key: MCHECKSTYLE-421
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-421
>             Project: Maven Checkstyle Plugin
>          Issue Type: Bug
>          Components: checkstyle:check
>    Affects Versions: 3.2.0
>            Reporter: Delany
>            Priority: Major
>
> Firstly, it seems that the term "violation" is mutable - the plugin gets to decide what is and is not a violation. So when a checkstyle check fails I am calling that an "audit event".
> Audit events produced by configuring consoleOutput to true are being logged to stdout. I run all my builds with `-Dorg.slf4j.simpleLogger.defaultLogLevel=warn` so I dont see these.
> There should probably also be an example in the documentation of how to configure errors to fail the build while displaying warnings to the console, as this is surely the most natural assumption when someone runs the check goal?
> [https://stackoverflow.com/questions/10488137/maven-checkstyle-plugin-print-warnings-to-console]
> Please also make
> {noformat}
> Audit done.{noformat}
> like
> {noformat}
> [mvn-builder-artifact] [INFO] org.apache.maven.plugins.checkstyle.exec.DefaultCheckstyleExecutor - Starting audit...{noformat}
> as an info level event, or remove it.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)